base/values.h - Issue 2419363002: Remove deprecated ListValue::Append(Value*) overload on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.h

Issue 2419363002: Remove deprecated ListValue::Append(Value*) overload on CrOS. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.h

diff --git a/base/values.h b/base/values.h

index 43d400c659924b1e52f4eb5bb420169aa3297aa5..1d270b566087434168148512ac487ef752f00c81 100644

--- a/base/values.h

+++ b/base/values.h

@@ -457,7 +457,7 @@ class BASE_EXPORT ListValue : public Value {

// Appends a Value to the end of the list.

void Append(std::unique_ptr<Value> in_value);

-#if !defined(OS_LINUX) || defined(OS_CHROMEOS)

+#if !defined(OS_LINUX)

// Deprecated version of the above. TODO(estade): remove.

void Append(Value* in_value);

#endif

« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »