Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2419363002: Remove deprecated ListValue::Append(Value*) overload on CrOS. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated ListValue::Append(Value*) overload on CrOS. BUG=581865 R=avi@chromium.org Committed: https://crrev.com/23779e84f947f059a7655819f0ec658c1c37bf44 Cr-Commit-Position: refs/heads/master@{#425608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/values.h View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dcheng
It built locally as of this afternoon. Hopefully it still builds now.
4 years, 2 months ago (2016-10-17 00:39:45 UTC) #5
Avi (use Gerrit)
lgtm 🎉
4 years, 2 months ago (2016-10-17 00:41:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419363002/1
4 years, 2 months ago (2016-10-17 00:47:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 02:19:23 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 02:20:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23779e84f947f059a7655819f0ec658c1c37bf44
Cr-Commit-Position: refs/heads/master@{#425608}

Powered by Google App Engine
This is Rietveld 408576698