Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2419333002: Skip SkBitmapProvider instantiation in SkImageShader::onContextSize (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Skip SkBitmapProvider instantiation in SkImageShader::onContextSize No reason to delegate through a SkBitmapProvider AFAICT. This avoids some ref churn. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2419333002 Committed: https://skia.googlesource.com/skia/+/dc87a7d8ea51b05ba2e8d86a2665461ff641b971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/image/SkImageShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
f(malita)
4 years, 2 months ago (2016-10-16 13:57:34 UTC) #2
reed1
lgtm
4 years, 2 months ago (2016-10-17 12:54:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419333002/1
4 years, 2 months ago (2016-10-17 13:08:32 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 13:09:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dc87a7d8ea51b05ba2e8d86a2665461ff641b971

Powered by Google App Engine
This is Rietveld 408576698