Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2419163002: More fix on generating correct C++ symbol name for scoped native enums (Closed)

Created:
4 years, 2 months ago by xhwang
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More fix on generating correct C++ symbol name for scoped native enums This is a follow up of https://crrev.com/50ba000ec3132d4b12f55b1ff46e08407843e605 R=rockot@chromium.org BUG=655919 TEST=Tested locally Committed: https://crrev.com/efd2ed209baaa86c49442114e1d812bc19808034 Cr-Commit-Position: refs/heads/master@{#425492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
Ken: PTAL
4 years, 2 months ago (2016-10-14 20:55:17 UTC) #1
Ken Rockot(use gerrit already)
Oops, thanks. LGTM
4 years, 2 months ago (2016-10-14 21:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419163002/1
4 years, 2 months ago (2016-10-14 21:16:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 22:18:34 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 22:20:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efd2ed209baaa86c49442114e1d812bc19808034
Cr-Commit-Position: refs/heads/master@{#425492}

Powered by Google App Engine
This is Rietveld 408576698