mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl - Issue 2419163002: More fix on generating correct C++ symbol name for scoped native enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

Issue 2419163002: More fix on generating correct C++ symbol name for scoped native enums (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

index bb5acd934333c149e94912d258c0630b5ded7bbd..f718276c2a9f370886c9b243d0c8618415f184d3 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

@@ -50,7 +50,8 @@ class {{union.name}}_Data;

{%- from "enum_macros.tmpl" import enum_data_decl -%}

{%- for enum in all_enums %}

{%- if enum|is_native_only_kind %}

-using {{enum.name}}_Data = mojo::internal::NativeEnum_Data;

+using {{enum|get_name_for_kind(flatten_nested_kind=True)}}_Data =

+ mojo::internal::NativeEnum_Data;

{%- else %}

{%- endif %}

« no previous file with comments | « no previous file | no next file » | no next file with comments »