Use high precision texture format during srgb conversion emulation for blitFramebuffer

Use high precision texture format during srgb conversion emulation for blitFramebuffer

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b3ef4848b1a9eef89def84560448821285acb5ae
Cr-Commit-Position: refs/heads/master@{#425968}

[yunchao, 2016-10-15 14:21:50]

Description was changed from

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=
==========

to

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-10-15 14:22:22]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 14:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-10-15 14:47:36]

Description was changed from

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-10-15 14:47:36]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2016-10-15 14:49:32]

Zhenyao and Ken, PTAL, Thanks a lot! Please see the discussion at
https://codereview.chromium.org/2420813002/

[commit-bot: I haz the power, 2016-10-15 14:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 14:52:18]

Dry run: Exceeded global retry quota

[Zhenyao Mo, 2016-10-17 20:58:06]

On 2016/10/15 14:49:32, yunchao wrote:
> Zhenyao and Ken, PTAL, Thanks a lot! Please see the discussion at
> https://codereview.chromium.org/2420813002/

If you don't do checking that the format is color-renderable, then at least do a
DCHECK that the underlying driver isn't ES.

[yunchao, 2016-10-18 00:19:25]

On 2016/10/17 20:58:06, Zhenyao Mo wrote:
> On 2016/10/15 14:49:32, yunchao wrote:
> > Zhenyao and Ken, PTAL, Thanks a lot! Please see the discussion at
> > https://codereview.chromium.org/2420813002/
> 
> If you don't do checking that the format is color-renderable, then at least do
a
> DCHECK that the underlying driver isn't ES.

OK. I have updated the code as you suggested, Zhenyao. PTAL.

[Zhenyao Mo, 2016-10-18 02:20:35]

https://codereview.chromium.org/2419153003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_srgb_converter.cc (right):

https://codereview.chromium.org/2419153003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_srgb_converter.cc:204:
DCHECK(feature_info_->context_type() != CONTEXT_TYPE_OPENGLES2 &&
This is incorrect. If context_type() is ES2 or ES3() in command buffer, it might
still be OK.  It's the underlying driver can't be ES.

featureInof_->gl_driver_info().is_es

[yunchao, 2016-10-18 07:42:52]

Yeah... I made a mistake here. The code has been updated, Zhenyao.

https://codereview.chromium.org/2419153003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_srgb_converter.cc (right):

https://codereview.chromium.org/2419153003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_srgb_converter.cc:204:
DCHECK(feature_info_->context_type() != CONTEXT_TYPE_OPENGLES2 &&
On 2016/10/18 02:20:35, Zhenyao Mo wrote:
> This is incorrect. If context_type() is ES2 or ES3() in command buffer, it
might
> still be OK.  It's the underlying driver can't be ES.
> 
> featureInof_->gl_driver_info().is_es

Done.

[yunchao, 2016-10-18 07:43:44]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 07:44:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 09:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 09:34:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Zhenyao Mo, 2016-10-18 14:48:22]

On 2016/10/18 07:42:52, yunchao wrote:
> Yeah... I made a mistake here. The code has been updated, Zhenyao.
> 
>
https://codereview.chromium.org/2419153003/diff/20001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/gles2_cmd_srgb_converter.cc (right):
> 
>
https://codereview.chromium.org/2419153003/diff/20001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_srgb_converter.cc:204:
> DCHECK(feature_info_->context_type() != CONTEXT_TYPE_OPENGLES2 &&
> On 2016/10/18 02:20:35, Zhenyao Mo wrote:
> > This is incorrect. If context_type() is ES2 or ES3() in command buffer, it
> might
> > still be OK.  It's the underlying driver can't be ES.
> > 
> > featureInof_->gl_driver_info().is_es
> 
> Done.

lgtm

[yunchao, 2016-10-18 15:25:34]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-10-18 15:26:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 15:31:43]

Description was changed from

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-18 15:31:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-18 15:35:34]

Description was changed from

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use high precision texture format during srgb conversion emulation for
blitFramebuffer

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b3ef4848b1a9eef89def84560448821285acb5ae
Cr-Commit-Position: refs/heads/master@{#425968}
==========

[commit-bot: I haz the power, 2016-10-18 15:35:35]

Patchset 3 (id:??) landed as
https://crrev.com/b3ef4848b1a9eef89def84560448821285acb5ae
Cr-Commit-Position: refs/heads/master@{#425968}