Add unit test for DefaultSchemeHostPort

Add unit test for DefaultSchemeHostPort

The url utility function ought to have a unit test to verify its basic
behavior of converting schemes to their default port. This adds those
unit tests.

R=mkwst@chromium.org

Committed: https://crrev.com/036284096750d9f7e565a31530cd875dec466b09
Cr-Commit-Position: refs/heads/master@{#425321}

[jww, 2016-10-14 14:27:43]

Description was changed from

==========
Add unit test for DefaultSchemeHostPort

The url utility function ought to have a unit test to verify its basic
behavior of converting schemes to their default port. This adds those
unit tests.

R=nasko@chromium.org
==========

to

==========
Add unit test for DefaultSchemeHostPort

The url utility function ought to have a unit test to verify its basic
behavior of converting schemes to their default port. This adds those
unit tests.

R=mkwst@chromium.org
==========

[jww, 2016-10-14 14:27:43]

jww@chromium.org changed reviewers:
+ mkwst@chromium.org
- nasko@chromium.org

[jww, 2016-10-14 14:28:44]

Mike, per Nasko's suggestion, this is a separate CL to add a unit test for
DefaultSchemeHostPort, split from https://codereview.chromium.org/2403713002/.

[Mike West, 2016-10-14 14:32:26]

LGTM.

https://codereview.chromium.org/2419083002/diff/1/url/url_canon_unittest.cc
File url/url_canon_unittest.cc (right):

https://codereview.chromium.org/2419083002/diff/1/url/url_canon_unittest.cc#n...
url/url_canon_unittest.cc:2178: const std::string scheme;
Nit: If you make this `const char[]`, then you won't have to convert to
`c_str()` below.

[jww, 2016-10-14 14:39:23]

https://codereview.chromium.org/2419083002/diff/1/url/url_canon_unittest.cc
File url/url_canon_unittest.cc (right):

https://codereview.chromium.org/2419083002/diff/1/url/url_canon_unittest.cc#n...
url/url_canon_unittest.cc:2178: const std::string scheme;
On 2016/10/14 14:32:26, Mike West wrote:
> Nit: If you make this `const char[]`, then you won't have to convert to
> `c_str()` below.

Done.

[jww, 2016-10-14 14:39:29]

The CQ bit was checked by jww@chromium.org

[jww, 2016-10-14 14:39:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2419083002/#ps20001
(title: "Nit")

[commit-bot: I haz the power, 2016-10-14 14:39:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 14:49:49]

Description was changed from

==========
Add unit test for DefaultSchemeHostPort

The url utility function ought to have a unit test to verify its basic
behavior of converting schemes to their default port. This adds those
unit tests.

R=mkwst@chromium.org
==========

to

==========
Add unit test for DefaultSchemeHostPort

The url utility function ought to have a unit test to verify its basic
behavior of converting schemes to their default port. This adds those
unit tests.

R=mkwst@chromium.org
==========

[commit-bot: I haz the power, 2016-10-14 14:49:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 14:51:35]

Description was changed from

==========
Add unit test for DefaultSchemeHostPort

The url utility function ought to have a unit test to verify its basic
behavior of converting schemes to their default port. This adds those
unit tests.

R=mkwst@chromium.org
==========

to

==========
Add unit test for DefaultSchemeHostPort

The url utility function ought to have a unit test to verify its basic
behavior of converting schemes to their default port. This adds those
unit tests.

R=mkwst@chromium.org

Committed: https://crrev.com/036284096750d9f7e565a31530cd875dec466b09
Cr-Commit-Position: refs/heads/master@{#425321}
==========

[commit-bot: I haz the power, 2016-10-14 14:51:36]

Patchset 2 (id:??) landed as
https://crrev.com/036284096750d9f7e565a31530cd875dec466b09
Cr-Commit-Position: refs/heads/master@{#425321}