Add local variable declaration token position to service protocol

Add local variable declaration token position to service protocol

- [x] Add three public fields to the "BoundVariable" service type: declarationTokenPos, scopeStartTokenPos, and scopeEndTokenPos.
- [x] Extend LocalVarDescriptors to hold the declaration token position (it already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=

[Cutch, 2016-10-14 21:10:43]

Description was changed from

==========
Add local variable declaration token position to service protocol

Fixes #25569

BUG=
==========

to

==========
Add local variable declaration token position to service protocol

Fixes #25569

BUG=
==========

[Cutch, 2016-10-14 21:10:43]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com, turnidge@google.com

[Cutch, 2016-10-14 21:10:51]

Description was changed from

==========
Add local variable declaration token position to service protocol

Fixes #25569

BUG=
==========

to

==========
Add local variable declaration token position to service protocol

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
==========

[Cutch, 2016-10-14 22:12:55]

Description was changed from

==========
Add local variable declaration token position to service protocol

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
==========

to

==========
Add local variable declaration token position to service protocol

- [x] Add three public fields to the "BoundVariable" service type:
declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming
suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it
already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function
parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
==========

[rmacnak, 2016-10-14 23:10:38]

lgtm

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:3419: // Line and column numbers
are
...are 1-origin in the VM.

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:3671: var beginPos =
descriptor['visibleStartTokenPos'];
Consider scopeStart/EndTokenPos

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/local_variable_declaration_test.dart
(right):

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/local_variable_declaration_test.dart:26:
debugger();
In Dart, a variable is not in scope during its initialization. Maybe also check
'bar' is not in scope here.

[Cutch, 2016-10-17 18:17:27]

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:3419: // Line and column numbers
are
On 2016/10/14 23:10:38, rmacnak wrote:
> ...are 1-origin in the VM.

Done.

https://codereview.chromium.org/2419013004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:3671: var beginPos =
descriptor['visibleStartTokenPos'];
On 2016/10/14 23:10:38, rmacnak wrote:
> Consider scopeStart/EndTokenPos

Done.

[Cutch, 2016-10-17 18:18:30]

Description was changed from

==========
Add local variable declaration token position to service protocol

- [x] Add three public fields to the "BoundVariable" service type:
declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming
suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it
already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function
parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
==========

to

==========
Add local variable declaration token position to service protocol

- [x] Add three public fields to the "BoundVariable" service type:
declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming
suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it
already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function
parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8061bd5a8ac94934c1dbcb99010364eafe392bc8
==========

[Cutch, 2016-10-17 18:18:31]

Committed patchset #4 (id:60001) manually as
8061bd5a8ac94934c1dbcb99010364eafe392bc8 (presubmit successful).

[Cutch, 2016-10-17 18:18:33]

Description was changed from

==========
Add local variable declaration token position to service protocol

- [x] Add three public fields to the "BoundVariable" service type:
declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming
suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it
already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function
parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8061bd5a8ac94934c1dbcb99010364eafe392bc8
==========

to

==========
Add local variable declaration token position to service protocol

- [x] Add three public fields to the "BoundVariable" service type:
declarationTokenPos, scopeStartTokenPos, and scopeEndTokenPos.
- [x] Extend LocalVarDescriptors to hold the declaration token position (it
already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function
parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
==========