Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2419013004: Add local variable declaration token position to service protocol (Closed)
Patch Set: ... Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.cc
diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc
index e3320efff78febc5b3ddc987439b851c84b0bfee..0aff92bde22c049fe019ecf25664c11b8a31faf7 100644
--- a/runtime/vm/kernel_to_il.cc
+++ b/runtime/vm/kernel_to_il.cc
@@ -41,13 +41,19 @@ void ScopeBuilder::ExitScope() { scope_ = scope_->parent(); }
LocalVariable* ScopeBuilder::MakeVariable(const dart::String& name) {
return new (Z)
- LocalVariable(TokenPosition::kNoSource, name, Object::dynamic_type());
+ LocalVariable(TokenPosition::kNoSource,
+ TokenPosition::kNoSource,
+ name,
+ Object::dynamic_type());
}
LocalVariable* ScopeBuilder::MakeVariable(const dart::String& name,
const Type& type) {
- return new (Z) LocalVariable(TokenPosition::kNoSource, name, type);
+ return new (Z) LocalVariable(TokenPosition::kNoSource,
+ TokenPosition::kNoSource,
+ name,
+ type);
}
@@ -2503,7 +2509,10 @@ LocalVariable* FlowGraphBuilder::MakeTemporary() {
intptr_t index = stack_->definition()->temp_index();
OS::SNPrint(name, 64, ":temp%" Pd, index);
LocalVariable* variable = new (Z) LocalVariable(
- TokenPosition::kNoSource, H.DartSymbol(name), Object::dynamic_type());
+ TokenPosition::kNoSource,
+ TokenPosition::kNoSource,
+ H.DartSymbol(name),
+ Object::dynamic_type());
// Set the index relative to the base of the expression stack including
// outgoing arguments.
variable->set_index(parsed_function_->first_stack_local_index() -
@@ -2764,7 +2773,9 @@ FlowGraph* FlowGraphBuilder::BuildGraphOfFunction(FunctionNode* function,
// create one directly.
LocalVariable* parameter =
new (Z) LocalVariable(TokenPosition::kNoSource,
- Symbols::TempParam(), Object::dynamic_type());
+ TokenPosition::kNoSource,
+ Symbols::TempParam(),
+ Object::dynamic_type());
parameter->set_index(parameter_index);
// Mark the stack variable so it will be ignored by the code for
// try/catch.
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698