Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2418983004: Enable PIN unlock by default. (Closed)

Created:
4 years, 2 months ago by jdufault
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PIN unlock by default. Approved for m57 in crbug.com/666899. BUG=603217 Committed: https://crrev.com/3056b258be9b7bfcc125199e2d909aa2c2455b81 Cr-Commit-Position: refs/heads/master@{#438918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/chrome_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
jdufault
stevenjb@ please take a quick look. Thanks!
4 years ago (2016-12-12 20:25:20 UTC) #5
stevenjb
lgtm
4 years ago (2016-12-12 21:21:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418983004/1
4 years ago (2016-12-12 21:24:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/354815)
4 years ago (2016-12-13 01:37:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418983004/1
4 years ago (2016-12-15 00:32:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/334929)
4 years ago (2016-12-15 00:41:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418983004/1
4 years ago (2016-12-15 20:08:25 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 20:47:36 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-15 20:51:55 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3056b258be9b7bfcc125199e2d909aa2c2455b81
Cr-Commit-Position: refs/heads/master@{#438918}

Powered by Google App Engine
This is Rietveld 408576698