[Devtools] Added simplified/latency view to network timeline experiment

[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG=653738
Committed: https://crrev.com/0ed6c761317066bfd0d24d3a2239c943dc3b83b5
Cr-Commit-Position: refs/heads/master@{#426551}

[allada, 2016-10-14 00:14:56]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-14 00:16:20]

PTL

[dgozman, 2016-10-17 21:36:16]

https://codereview.chromium.org/2418953002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2418953002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:400:
_borderColorForResourceType: function(request)
Let's calculate these once and for all next to background colors for resource
types.

https://codereview.chromium.org/2418953002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:440:
gradient.addColorStop(1, /** @type {string} */ (parsedColor.asString(null)));
Let's cache this string as well.

[allada, 2016-10-19 19:03:55]

PTaL

https://codereview.chromium.org/2418953002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2418953002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:400:
_borderColorForResourceType: function(request)
On 2016/10/17 21:36:16, dgozman wrote:
> Let's calculate these once and for all next to background colors for resource
> types.

Done.

https://codereview.chromium.org/2418953002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:440:
gradient.addColorStop(1, /** @type {string} */ (parsedColor.asString(null)));
On 2016/10/17 21:36:16, dgozman wrote:
> Let's cache this string as well.

Done.

[dgozman, 2016-10-19 19:52:33]

lgtm

https://codereview.chromium.org/2418953002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2418953002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:416:
var resultColor = /** @type {string} */ (parsedColor.asString(null))
semicolon

[allada, 2016-10-19 23:46:08]

Patchset #5 (id:100001) has been deleted

[allada, 2016-10-20 01:43:46]

Description was changed from

==========
[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG=653738

changes
==========

to

==========
[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG=653738
==========

[allada, 2016-10-20 01:55:16]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-20 01:55:17]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2418953002/#ps160001
(title: "Merge branch 'NETWORK_TIMELINE_7_POPOVER' into
NETWORK_TIMELINE_8_LATENCY_VIEW")

[commit-bot: I haz the power, 2016-10-20 01:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 01:56:10]

This CL has an open dependency (Issue 2414853002 Patch 160001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[allada, 2016-10-20 02:20:00]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-10-20 02:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 02:20:35]

This CL has an open dependency (Issue 2414853002 Patch 160001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[allada, 2016-10-20 05:31:12]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-10-20 05:31:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 05:33:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 05:33:51]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[allada, 2016-10-20 15:39:38]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-10-20 15:40:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 15:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 15:43:10]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[allada, 2016-10-20 15:49:26]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-20 15:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2418953002/#ps180001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into NETWORK_TIMELINE_8_LAT…")

[commit-bot: I haz the power, 2016-10-20 15:49:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:00:34]

Description was changed from

==========
[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG=653738
==========

[commit-bot: I haz the power, 2016-10-20 19:00:35]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-10-21 13:20:56]

Description was changed from

==========
[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG=653738

Committed: https://crrev.com/0ed6c761317066bfd0d24d3a2239c943dc3b83b5
Cr-Commit-Position: refs/heads/master@{#426551}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:57]

Patchset 8 (id:??) landed as
https://crrev.com/0ed6c761317066bfd0d24d3a2239c943dc3b83b5
Cr-Commit-Position: refs/heads/master@{#426551}