Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2418923002: [Merge] [Android] Fix logcat extraction code. (Closed)

Created:
4 years, 2 months ago by Ilya Sherman
Modified:
4 years, 2 months ago
Reviewers:
Maria
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Merge] [Android] Fix logcat extraction code. Currently, logcat extraction often fails, because the Process's output buffer gets saturated with the logcat output. I've reimplemented the code to manually grab the last N lines of the logcat output, and this implementation should avoid the buffer saturation issue. Note: When the logcat extraction fails, it actually causes the thread to hang, which means that crash reports don't get processed! BUG=654155 TEST=junit_tests R=mariakhomenko@chromium.org Review-Url: https://codereview.chromium.org/2400403002 Cr-Commit-Position: refs/heads/master@{#424277} (cherry picked from commit a8aba3c20875329d9f977253d5375552c33d6b4c) Committed: https://chromium.googlesource.com/chromium/src/+/7a2b5a6385d8e82c72df9a20375801bc90e136d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -52 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java View 2 chunks +29 lines, -24 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java View 3 chunks +10 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ilya Sherman
4 years, 2 months ago (2016-10-13 22:11:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a2b5a6385d8e82c72df9a20375801bc90e136d0.

Powered by Google App Engine
This is Rietveld 408576698