[Android] Fix logcat extraction code.

[Android] Fix logcat extraction code.

Currently, logcat extraction often fails, because the Process's output
buffer gets saturated with the logcat output.  I've reimplemented the
code to manually grab the last N lines of the logcat output, and this
implementation should avoid the buffer saturation issue.

Note: When the logcat extraction fails, it actually causes the thread to
hang, which means that crash reports don't get processed!

BUG=654155
TEST=junit_tests
R=mariakhomenko@chromium.org

Committed: https://crrev.com/a8aba3c20875329d9f977253d5375552c33d6b4c
Cr-Commit-Position: refs/heads/master@{#424277}

[Ilya Sherman, 2016-10-08 01:16:41]

https://codereview.chromium.org/2400403002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java
(right):

https://codereview.chromium.org/2400403002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java:10:
import static org.junit.Assert.assertArrayEquals;
By the way, I'm getting an presubmit error telling me that this import is not
sorted correctly.  Is there a tool that I can run to sort the imports
"correctly"?  I use Emacs as my code editor, so the IDE-based solutions that the
presubmit script recommends are not the most helpful =)

[Maria, 2016-10-10 17:55:35]

lgtm

https://codereview.chromium.org/2400403002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java
(right):

https://codereview.chromium.org/2400403002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java:10:
import static org.junit.Assert.assertArrayEquals;
On 2016/10/08 01:16:41, Ilya Sherman wrote:
> By the way, I'm getting an presubmit error telling me that this import is not
> sorted correctly.  Is there a tool that I can run to sort the imports
> "correctly"?  I use Emacs as my code editor, so the IDE-based solutions that
the
> presubmit script recommends are not the most helpful =)

Sorry, I use Eclipse and I am not sure there's a command-line tool for that. The
presubmit should be providing you with ordering though... I don't quite see what
the issue is visually either.

[Ilya Sherman, 2016-10-10 21:47:03]

https://codereview.chromium.org/2400403002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java
(right):

https://codereview.chromium.org/2400403002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java:10:
import static org.junit.Assert.assertArrayEquals;
On 2016/10/10 17:55:35, Maria wrote:
> On 2016/10/08 01:16:41, Ilya Sherman wrote:
> > By the way, I'm getting an presubmit error telling me that this import is
not
> > sorted correctly.  Is there a tool that I can run to sort the imports
> > "correctly"?  I use Emacs as my code editor, so the IDE-based solutions that
> the
> > presubmit script recommends are not the most helpful =)
> 
> Sorry, I use Eclipse and I am not sure there's a command-line tool for that.
The
> presubmit should be providing you with ordering though... I don't quite see
what
> the issue is visually either.

Hmm, the presubmit doesn't provide me with an ordering -- it just gives:

** Presubmit ERRORS **
 
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java:10:
Wrong order for org.junit.Assert.assertArrayEquals import. Use
:JavaImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports. An
importorder file for configuring Eclipse can be found at
//tools/android/eclipse/android.importorder.
 
chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java:14:
Wrong order for org.junit.Test import. Use :JavaImportOrganize (ECLIM) or
Ctrl+Shift+O (Eclipse) to sort imports. An importorder file for configuring
Eclipse can be found at //tools/android/eclipse/android.importorder.

I guess I'll try to commit this and see if the presubmit warning blocks the CQ;
and if it does, see about installing Eclipse to fix import ordering.

[Ilya Sherman, 2016-10-10 21:47:08]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:47:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:57:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ilya Sherman, 2016-10-10 22:44:54]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2016-10-10 22:44:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2400403002/#ps20001
(title: "Fix import order")

[commit-bot: I haz the power, 2016-10-10 22:45:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 23:15:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 23:17:34]

Description was changed from

==========
[Android] Fix logcat extraction code.

Currently, logcat extraction often fails, because the Process's output
buffer gets saturated with the logcat output.  I've reimplemented the
code to manually grab the last N lines of the logcat output, and this
implementation should avoid the buffer saturation issue.

Note: When the logcat extraction fails, it actually causes the thread to
hang, which means that crash reports don't get processed!

BUG=654155
TEST=junit_tests
R=mariakhomenko@chromium.org
==========

to

==========
[Android] Fix logcat extraction code.

Currently, logcat extraction often fails, because the Process's output
buffer gets saturated with the logcat output.  I've reimplemented the
code to manually grab the last N lines of the logcat output, and this
implementation should avoid the buffer saturation issue.

Note: When the logcat extraction fails, it actually causes the thread to
hang, which means that crash reports don't get processed!

BUG=654155
TEST=junit_tests
R=mariakhomenko@chromium.org

Committed: https://crrev.com/a8aba3c20875329d9f977253d5375552c33d6b4c
Cr-Commit-Position: refs/heads/master@{#424277}
==========

[commit-bot: I haz the power, 2016-10-10 23:17:35]

Patchset 2 (id:??) landed as
https://crrev.com/a8aba3c20875329d9f977253d5375552c33d6b4c
Cr-Commit-Position: refs/heads/master@{#424277}