DevTools: [Persistence] implement automapping

DevTools: [Persistence] implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG=642583
Committed: https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d
Cr-Commit-Position: refs/heads/master@{#427419}

[lushnikov, 2016-10-24 22:25:55]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2016-10-24 22:25:56]

please, take a look

[lushnikov, 2016-10-24 22:26:03]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 22:26:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:29:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-10-24 23:17:24]

Description was changed from

==========
DevTools: implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG=642583
==========

to

==========
DevTools: [Persistence] implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG=642583
==========

[lushnikov, 2016-10-24 23:55:52]

In UI, showed the stub in the "Mappings" section of workspace, and hid the
context menu options to map network resorces.

Screenshot: http://imgur.com/a/C7TVk

[lushnikov, 2016-10-25 00:04:53]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 00:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-10-25 00:53:57]

imgur is down; uploaded to crbug

[dgozman, 2016-10-25 01:51:48]

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sane.html
(right):

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sane.html:53:
InspectorTest.addFiles(fs, {
Let's have two different resources mapped with similar path ending, e.g.
xxx/module.json.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
(right):

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:21:
this._urlToFile = new Map();
_fileSystemUISourceCodes

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:27:
this._activeFolders = new WebInspector.Automapping.FolderIndex(pathEncoder);
_activeFoldersIndex

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:36: for
(var fileSystem of
workspace.projectsForType(WebInspector.projectTypes.FileSystem))
workspace.projects()

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:152: if
(!networkSourceCode[WebInspector.Automapping._isProcessing])
We need identity instead of boolean.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:222: var
activeFiles = similarFiles.filter(file =>
!!this._activeFolders.closestParentFolder(file.url()))
missing semicolon

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:224: if
(!networkMetadata) {
|| (!modificationTime && !contentSize)

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:21:
this._mapping = new WebInspector.Automapping(workspace,
this._onBindingCreated.bind(this), this._onBindingRemoved.bind(this));
Let's wait for all file systems to load before creating mapping.

[commit-bot: I haz the power, 2016-10-25 01:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 01:57:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2016-10-25 03:32:41]

please, take another look

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sane.html
(right):

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sane.html:53:
InspectorTest.addFiles(fs, {
On 2016/10/25 01:51:47, dgozman wrote:
> Let's have two different resources mapped with similar path ending, e.g.
> xxx/module.json.

Done.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
(right):

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:21:
this._urlToFile = new Map();
On 2016/10/25 01:51:47, dgozman wrote:
> _fileSystemUISourceCodes

Done.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:27:
this._activeFolders = new WebInspector.Automapping.FolderIndex(pathEncoder);
On 2016/10/25 01:51:48, dgozman wrote:
> _activeFoldersIndex

Done.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:36: for
(var fileSystem of
workspace.projectsForType(WebInspector.projectTypes.FileSystem))
On 2016/10/25 01:51:47, dgozman wrote:
> workspace.projects()

Done.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:152: if
(!networkSourceCode[WebInspector.Automapping._isProcessing])
On 2016/10/25 01:51:47, dgozman wrote:
> We need identity instead of boolean.

Done.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:222: var
activeFiles = similarFiles.filter(file =>
!!this._activeFolders.closestParentFolder(file.url()))
On 2016/10/25 01:51:48, dgozman wrote:
> missing semicolon

Done.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js:224: if
(!networkMetadata) {
On 2016/10/25 01:51:48, dgozman wrote:
> || (!modificationTime && !contentSize)

Done.

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2418813005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:21:
this._mapping = new WebInspector.Automapping(workspace,
this._onBindingCreated.bind(this), this._onBindingRemoved.bind(this));
On 2016/10/25 01:51:48, dgozman wrote:
> Let's wait for all file systems to load before creating mapping.

We already wait for them in the FileSystemWorkspaceBinding; thanks for the
heads-up though!

[lushnikov, 2016-10-25 03:32:47]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 03:33:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 05:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 05:03:09]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-25 18:25:03]

lgtm

[lushnikov, 2016-10-25 18:26:52]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:27:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:34:23]

Description was changed from

==========
DevTools: [Persistence] implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG=642583
==========

to

==========
DevTools: [Persistence] implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG=642583
==========

[commit-bot: I haz the power, 2016-10-25 18:34:24]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-10-25 18:38:32]

Description was changed from

==========
DevTools: [Persistence] implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG=642583
==========

to

==========
DevTools: [Persistence] implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG=642583

Committed: https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d
Cr-Commit-Position: refs/heads/master@{#427419}
==========

[commit-bot: I haz the power, 2016-10-25 18:38:34]

Patchset 10 (id:??) landed as
https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d
Cr-Commit-Position: refs/heads/master@{#427419}