Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js

Issue 2418813005: DevTools: [Persistence] implement automapping (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js b/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js
index 2a0780f3c358d884b7c7d0b1ca3d87fe03e830c0..a00c678f00555760085ee05c530657885e03aea3 100644
--- a/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js
+++ b/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js
@@ -47,14 +47,18 @@ WebInspector.EditFileSystemView = function(fileSystemPath)
WebInspector.isolatedFileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.ExcludedFolderRemoved, this._update, this)
];
- var mappingsHeader = this.contentElement.createChild("div", "file-system-header");
- mappingsHeader.createChild("div", "file-system-header-text").textContent = WebInspector.UIString("Mappings");
- mappingsHeader.appendChild(createTextButton(WebInspector.UIString("Add"), this._addMappingButtonClicked.bind(this), "add-button"));
this._mappingsList = new WebInspector.ListWidget(this);
this._mappingsList.element.classList.add("file-system-list");
this._mappingsList.registerRequiredCSS("settings/editFileSystemView.css");
var mappingsPlaceholder = createElementWithClass("div", "file-system-list-empty");
- mappingsPlaceholder.textContent = WebInspector.UIString("No mappings");
+ var mappingsHeader = this.contentElement.createChild("div", "file-system-header");
+ mappingsHeader.createChild("div", "file-system-header-text").textContent = WebInspector.UIString("Mappings");
+ if (Runtime.experiments.isEnabled("persistence2")) {
+ mappingsPlaceholder.textContent = WebInspector.UIString("Mappings are inferred automatically via the 'Persistence 2.0' experiment.");
+ } else {
+ mappingsPlaceholder.textContent = WebInspector.UIString("No mappings");
+ mappingsHeader.appendChild(createTextButton(WebInspector.UIString("Add"), this._addMappingButtonClicked.bind(this), "add-button"));
+ }
this._mappingsList.setEmptyPlaceholder(mappingsPlaceholder);
this._mappingsList.show(this.contentElement);
@@ -86,6 +90,8 @@ WebInspector.EditFileSystemView.prototype = {
this._mappingsList.clear();
this._mappings = [];
+ if (Runtime.experiments.isEnabled("persistence2"))
+ return;
var mappings = WebInspector.fileSystemMapping.mappingEntries(this._fileSystemPath);
for (var entry of mappings) {
if (entry.configurable) {

Powered by Google App Engine
This is Rietveld 408576698