Reland: Make the CPDFXFA_App non-global

Reland: Make the CPDFXFA_App non-global

This reverts commit b685e6471075bebd26711bc183de3128f54932e3.

This CL changes CPDFXFA_App from a global object to a child of the CPDFXFA_Document objects.

BUG=pdfium:623
Committed: https://pdfium.googlesource.com/pdfium/+/f3736bca5f874b0889c5906ffbd74a405089f671

[dsinclair, 2016-10-13 18:03:26]

Description was changed from

==========
Reland: Make the CPDFXFA_App non-global

This reverts commit b685e6471075bebd26711bc183de3128f54932e3.

BUG=pdfium:623
==========

to

==========
Reland: Make the CPDFXFA_App non-global

This reverts commit b685e6471075bebd26711bc183de3128f54932e3.

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623
==========

[dsinclair, 2016-10-13 18:58:51]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-10-13 18:58:52]

PTAL. Patchset #1 is the original CL, PS#2 is the fix.

[dsinclair, 2016-10-13 18:58:55]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 18:59:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-13 19:04:49]

lgtm

[dsinclair, 2016-10-13 19:06:33]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-10-13 19:06:34]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:06:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:07:45]

Description was changed from

==========
Reland: Make the CPDFXFA_App non-global

This reverts commit b685e6471075bebd26711bc183de3128f54932e3.

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623
==========

to

==========
Reland: Make the CPDFXFA_App non-global

This reverts commit b685e6471075bebd26711bc183de3128f54932e3.

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623

Committed:
https://pdfium.googlesource.com/pdfium/+/f3736bca5f874b0889c5906ffbd74a405089...
==========

[commit-bot: I haz the power, 2016-10-13 19:07:46]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/f3736bca5f874b0889c5906ffbd74a405089...

[dsinclair, 2016-10-13 19:14:16]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2414883006/ by dsinclair@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.pdfium/builders/linux_xfa_asan_lsan/build....

[Tom Sepez, 2016-10-13 20:01:33]

https://codereview.chromium.org/2418653003/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_app.cpp (right):

https://codereview.chromium.org/2418653003/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_app.cpp:20: m_bOwnsIsolate =
FXJS_GetIsolate(&m_pIsolate);
thinking more about this ...

Can we now call CJS_Runtime::CJS_Runtime() instead of doing this directly?  I
hope that with your change, we now have the specific objects required to fully
init CJS, not just fxjs

[Tom Sepez, 2016-10-13 20:02:31]

On 2016/10/13 20:01:33, Tom Sepez wrote:
>
https://codereview.chromium.org/2418653003/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
> File fpdfsdk/fpdfxfa/cpdfxfa_app.cpp (right):
> 
>
https://codereview.chromium.org/2418653003/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
> fpdfsdk/fpdfxfa/cpdfxfa_app.cpp:20: m_bOwnsIsolate =
> FXJS_GetIsolate(&m_pIsolate);
> thinking more about this ...
> 
> Can we now call CJS_Runtime::CJS_Runtime() instead of doing this directly?  I
> hope that with your change, we now have the specific objects required to fully
> init CJS, not just fxjs

CPDFSDK_FormFillEnvironment::GetJSRuntime() actually.