fpdfsdk/cpdfsdk_formfillenvironment.cpp - Issue 2418653003: Reland: Make the CPDFXFA_App non-global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/cpdfsdk_formfillenvironment.cpp

Issue 2418653003: Reland: Make the CPDFXFA_App non-global (Closed)

Patch Set: Dispose of the isolate Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/cpdfsdk_formfillenvironment.cpp

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.cpp b/fpdfsdk/cpdfsdk_formfillenvironment.cpp

index 71b83b26553cd9953ad740f40d4a0ff7ec24a980..9ad7c9fd71ede3dc980286fdcdbe6eef7f0b2ef4 100644

--- a/fpdfsdk/cpdfsdk_formfillenvironment.cpp

+++ b/fpdfsdk/cpdfsdk_formfillenvironment.cpp

@@ -58,11 +58,6 @@ CPDFSDK_FormFillEnvironment::~CPDFSDK_FormFillEnvironment() {

// Those widgets may call things like KillTimer() as they are shutdown.

m_pFormFiller.reset();

-#ifdef PDF_ENABLE_XFA

- CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance();

- if (pProvider->m_pFormFillEnvList.GetSize() == 0)

- pProvider->SetJavaScriptInitialized(FALSE);

-#endif // PDF_ENABLE_XFA

if (m_pInfo && m_pInfo->Release)

m_pInfo->Release(m_pInfo);

}