Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2418643003: Add linux_use_bundled_binutils_override = true to build_overrides. (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add linux_use_bundled_binutils_override = true to build_overrides. This variable was introduced in https://codereview.chromium.org/2293853002 and causes builds to fail, since is not defined in libyuv. BUG=webrtc:6281 TBR=kjellander@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/9fb3c31b06ed7480ae380048d1542e575d6ea291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build_overrides/build.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fbarchard1
4 years, 2 months ago (2016-10-13 01:14:30 UTC) #1
fbarchard1
Committed patchset #1 (id:1) manually as 9fb3c31b06ed7480ae380048d1542e575d6ea291 (presubmit successful).
4 years, 2 months ago (2016-10-13 01:15:25 UTC) #4
kjellander_chromium
4 years, 2 months ago (2016-10-13 01:20:08 UTC) #6
Message was sent while issue was closed.
On 2016/10/13 01:15:25, fbarchard1 wrote:
> Committed patchset #1 (id:1) manually as
> 9fb3c31b06ed7480ae380048d1542e575d6ea291 (presubmit successful).

You mentioned WebRTC instead of libyuv in the commit message, but it's not the
end of the world (I updated the CL here at least, but the commit is already in
the git history).

lgtm

Powered by Google App Engine
This is Rietveld 408576698