Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2293853002: Add linux_use_bundled_binutils_override GN variable. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add linux_use_bundled_binutils_override GN variable. Committed: https://crrev.com/29afbc3212e9b2e1127a41615a2b87387b42364c Cr-Commit-Position: refs/heads/master@{#415333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M build_overrides/build.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
Is this what you had in mind?
4 years, 3 months ago (2016-08-30 16:33:55 UTC) #6
Dirk Pranke
Yup, pretty much. LGTM.
4 years, 3 months ago (2016-08-30 16:49:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293853002/1
4 years, 3 months ago (2016-08-30 17:14:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:18:22 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:20:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29afbc3212e9b2e1127a41615a2b87387b42364c
Cr-Commit-Position: refs/heads/master@{#415333}

Powered by Google App Engine
This is Rietveld 408576698