Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Issue 2418513002: [stubs] Drop LoadICStub and LoadICTrampolineStub (the non-TurboFan implementations of LoadIC dispatc (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Drop LoadICStub and LoadICTrampolineStub (the non-TurboFan implementations of LoadIC dispatchers). Because of the planned improvements of IC system it does not make sense to keep the old platform version of the stub around.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -555 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +0 lines, -57 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +0 lines, -55 lines 0 comments Download
M src/code-factory.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M src/code-stubs.h View 5 chunks +4 lines, -31 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -52 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +0 lines, -57 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +0 lines, -58 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +0 lines, -58 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +0 lines, -53 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +0 lines, -52 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-12 09:54:39 UTC) #10
Jakob Kummerow
LGTM with \o/
4 years, 2 months ago (2016-10-12 11:46:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418513002/20001
4 years, 2 months ago (2016-10-12 11:54:26 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-12 11:56:52 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 11:57:14 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a99cc4732385f2e5b2436186fc1fb21890dc006
Cr-Commit-Position: refs/heads/master@{#40211}

Powered by Google App Engine
This is Rietveld 408576698