Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: src/code-stubs.h

Issue 2418513002: [stubs] Drop LoadICStub and LoadICTrampolineStub (the non-TurboFan implementations of LoadIC dispatc (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 7a803622f1ffd3ddb015bc1e40ceb7a018b7a298..066808b4fb1352a301f898618ca3d066339e66c4 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -46,7 +46,6 @@ class ObjectLiteral;
V(StoreIC) \
V(KeyedStoreIC) \
V(KeyedLoadIC) \
- V(LoadIC) \
V(LoadGlobalIC) \
V(FastNewObject) \
V(FastNewRestParameter) \
@@ -61,7 +60,6 @@ class ObjectLiteral;
/* version of the corresponding stub is */ \
/* used universally */ \
V(CallICTrampoline) \
- V(LoadICTrampoline) \
V(KeyedLoadICTrampoline) \
V(KeyedStoreICTrampoline) \
V(StoreICTrampoline) \
@@ -2051,16 +2049,6 @@ class KeyedLoadGenericStub : public HydrogenCodeStub {
};
-class LoadICTrampolineStub : public PlatformCodeStub {
- public:
- explicit LoadICTrampolineStub(Isolate* isolate) : PlatformCodeStub(isolate) {}
-
- Code::Kind GetCodeKind() const override { return Code::LOAD_IC; }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(Load);
- DEFINE_PLATFORM_CODE_STUB(LoadICTrampoline, PlatformCodeStub);
-};
-
class LoadICTrampolineTFStub : public TurboFanCodeStub {
public:
explicit LoadICTrampolineTFStub(Isolate* isolate)
@@ -2094,14 +2082,15 @@ class LoadGlobalICTrampolineStub : public TurboFanCodeStub {
DEFINE_CODE_STUB(LoadGlobalICTrampoline, TurboFanCodeStub);
};
-class KeyedLoadICTrampolineStub : public LoadICTrampolineStub {
+class KeyedLoadICTrampolineStub : public PlatformCodeStub {
public:
explicit KeyedLoadICTrampolineStub(Isolate* isolate)
- : LoadICTrampolineStub(isolate) {}
+ : PlatformCodeStub(isolate) {}
Code::Kind GetCodeKind() const override { return Code::KEYED_LOAD_IC; }
- DEFINE_PLATFORM_CODE_STUB(KeyedLoadICTrampoline, LoadICTrampolineStub);
+ DEFINE_CALL_INTERFACE_DESCRIPTOR(Load);
+ DEFINE_PLATFORM_CODE_STUB(KeyedLoadICTrampoline, PlatformCodeStub);
};
class KeyedLoadICTrampolineTFStub : public LoadICTrampolineTFStub {
@@ -2191,22 +2180,6 @@ class CallICTrampolineStub : public PlatformCodeStub {
DEFINE_PLATFORM_CODE_STUB(CallICTrampoline, PlatformCodeStub);
};
-
-class LoadICStub : public PlatformCodeStub {
- public:
- explicit LoadICStub(Isolate* isolate) : PlatformCodeStub(isolate) {}
-
- void GenerateForTrampoline(MacroAssembler* masm);
-
- Code::Kind GetCodeKind() const override { return Code::LOAD_IC; }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadWithVector);
- DEFINE_PLATFORM_CODE_STUB(LoadIC, PlatformCodeStub);
-
- protected:
- void GenerateImpl(MacroAssembler* masm, bool in_frame);
-};
-
class LoadICTFStub : public TurboFanCodeStub {
public:
explicit LoadICTFStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
« no previous file with comments | « src/code-factory.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698