Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792, 654791
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/383d5dae3a02d516009ec4ae517e0a433877144f
Cr-Commit-Position: refs/heads/master@{#424798}

[Zhenyao Mo, 2016-10-12 00:23:25]

Description was changed from

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
==========

to

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-12 00:23:32]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 00:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-12 01:10:11]

piman: PTAL
others: FYI

[commit-bot: I haz the power, 2016-10-12 01:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 01:26:06]

Dry run: This issue passed the CQ dry run.

[piman, 2016-10-12 17:43:13]

LGTM, thanks. This should also fix crbug.com/654791 (the CopyTexSubImage3D
version), right?

[Zhenyao Mo, 2016-10-12 17:48:39]

On 2016/10/12 17:43:13, piman wrote:
> LGTM, thanks. This should also fix crbug.com/654791 (the CopyTexSubImage3D
> version), right?

Correct.

[Zhenyao Mo, 2016-10-12 17:48:56]

Description was changed from

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792,654791
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-12 17:51:36]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-12 17:52:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 18:36:05]

Description was changed from

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792,654791
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792,654791
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-12 18:36:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-12 18:39:36]

Description was changed from

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792,654791
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use gfx::Rect::Intersect() to clip for CopyTex{Sub}Image functions.

Also, if after the clipping, the area is empty, then no need to
process further for *Sub* functions - this gets rid of the overflow
issues in the following numerical computation.

BUG=654792,654791
TEST=gpu_unittests,webgl_conformance,affected gpu_fuzzer
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/383d5dae3a02d516009ec4ae517e0a433877144f
Cr-Commit-Position: refs/heads/master@{#424798}
==========

[commit-bot: I haz the power, 2016-10-12 18:39:37]

Patchset 1 (id:??) landed as
https://crrev.com/383d5dae3a02d516009ec4ae517e0a433877144f
Cr-Commit-Position: refs/heads/master@{#424798}