Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2418253002: Make updates to Panel menu (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make updates to Panel menu - add the information category to the speech menu, tables category to jump menu, overview to jump menu BUG=642129 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1aa68f4c6c4ec4cf8d3c8c65c7b00b08cae3ee35 Cr-Commit-Position: refs/heads/master@{#425488}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 15 (8 generated)
David Tseng
4 years, 2 months ago (2016-10-14 20:31:59 UTC) #4
dmazzoni
https://codereview.chromium.org/2418253002/diff/1/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd (right): https://codereview.chromium.org/2418253002/diff/1/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd#newcode196 chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:196: ChromeVox find in page How about "accessible find" or ...
4 years, 2 months ago (2016-10-14 20:47:17 UTC) #5
dmazzoni
lgtm
4 years, 2 months ago (2016-10-14 20:47:22 UTC) #6
David Tseng
https://codereview.chromium.org/2418253002/diff/1/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd (right): https://codereview.chromium.org/2418253002/diff/1/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd#newcode196 chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:196: ChromeVox find in page On 2016/10/14 20:47:16, dmazzoni wrote: ...
4 years, 2 months ago (2016-10-14 21:08:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418253002/1
4 years, 2 months ago (2016-10-14 21:09:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 22:08:01 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 22:09:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aa68f4c6c4ec4cf8d3c8c65c7b00b08cae3ee35
Cr-Commit-Position: refs/heads/master@{#425488}

Powered by Google App Engine
This is Rietveld 408576698