Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1878)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Issue 2418253002: Make updates to Panel menu (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
index 7e73afbcd8459281b5983eef0d04f8d170061ec2..6c51f5dd1efe92bf79615dea8d6c5ec3949dac54 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
@@ -271,13 +271,13 @@ Panel.onOpenMenus = function(opt_event, opt_activateMenuTitle) {
var categoryToMenu = {
'navigation': jumpMenu,
'jump_commands': jumpMenu,
+ 'overview': jumpMenu,
+ 'tables': jumpMenu,
'controlling_speech': speechMenu,
+ 'information': speechMenu,
'modifier_keys': chromevoxMenu,
'help_commands': chromevoxMenu,
- 'information': null, // Get link URL, get page title, etc.
- 'overview': null, // Headings list, etc.
- 'tables': null, // Table navigation.
'braille': null,
'developer': null};
@@ -310,7 +310,12 @@ Panel.onOpenMenus = function(opt_event, opt_activateMenuTitle) {
});
// Insert items from the bindings into the menus.
+ var sawBindingSet = {};
sortedBindings.forEach(goog.bind(function(binding) {
+ var command = binding.command;
+ if (sawBindingSet[command])
+ return;
+ sawBindingSet[command] = true;
var category = cvox.CommandStore.categoryForCommand(binding.command);
var menu = category ? categoryToMenu[category] : null;
if (binding.title && menu) {

Powered by Google App Engine
This is Rietveld 408576698