Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2418053002: Revert of [heap] Move slot filtering logic into sweeper. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Move slot filtering logic into sweeper. (patchset #4 id:60001 of https://codereview.chromium.org/2418773002/ ) Reason for revert: [Sheriff] Speculative revert for heap corruption on all platforms, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/12377 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/12379 https://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/4819 https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/16783 https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20-%20debug/builds/10007 Original issue's description: > [heap] Move slot filtering logic into sweeper. > > BUG=chromium:648568 > > Committed: https://crrev.com/18db69c38c93450c1ae957999fc48c465f111f00 > Cr-Commit-Position: refs/heads/master@{#40267} TBR=ulan@chromium.org,mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Committed: https://crrev.com/cdc3459a858a6b86e96cedf841f7b95e49fef272 Cr-Commit-Position: refs/heads/master@{#40292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -75 lines) Patch
M src/heap/mark-compact.cc View 6 chunks +9 lines, -21 lines 0 comments Download
M src/heap/remembered-set.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/remembered-set.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M src/heap/slot-set.h View 4 chunks +17 lines, -32 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 2 chunks +16 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Achenbach
Created Revert of [heap] Move slot filtering logic into sweeper.
4 years, 2 months ago (2016-10-14 06:58:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418053002/1
4 years, 2 months ago (2016-10-14 06:59:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 06:59:13 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdc3459a858a6b86e96cedf841f7b95e49fef272 Cr-Commit-Position: refs/heads/master@{#40292}
4 years, 2 months ago (2016-10-14 06:59:46 UTC) #7
Michael Achenbach
FYI: The redness stopped after this revert. Is it a problem getting a canary with ...
4 years, 2 months ago (2016-10-14 09:52:48 UTC) #8
Michael Hablich
On 2016/10/14 09:52:48, machenbach (slow) wrote: > FYI: The redness stopped after this revert. Is ...
4 years, 2 months ago (2016-10-14 09:59:26 UTC) #9
Yang
4 years, 2 months ago (2016-10-14 11:36:08 UTC) #10
Message was sent while issue was closed.
On 2016/10/14 09:59:26, Hablich wrote:
> On 2016/10/14 09:52:48, machenbach (slow) wrote:
> > FYI: The redness stopped after this revert. Is it a problem getting a canary
> > with this commit in?
> > 
> > @hablich: Can you check if we rolled in the range where this CL was in?
> 
> This CL is deployed on Canary 2890 in v8
> https://chromium.googlesource.com/v8/v8/+log/ec798714..24369beb.

Note: this revert seems to have fixed the flaky test failures.

Powered by Google App Engine
This is Rietveld 408576698