Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2418003: Added const to image parameters for ImageButton class. (Closed)

Created:
10 years, 6 months ago by whywhat
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Added const to image parameters for ImageButton class. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48748

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M views/controls/button/image_button.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M views/controls/button/image_button.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
whywhat
Please, take a look.
10 years, 6 months ago (2010-06-02 18:10:26 UTC) #1
sky
http://codereview.chromium.org/2418003/diff/1/3 File views/controls/button/image_button.h (right): http://codereview.chromium.org/2418003/diff/1/3#newcode25 views/controls/button/image_button.h:25: virtual void SetImage(ButtonState aState, const SkBitmap* anImage); Are there ...
10 years, 6 months ago (2010-06-02 18:25:41 UTC) #2
whywhat
http://codereview.chromium.org/2418003/diff/1/3 File views/controls/button/image_button.h (right): http://codereview.chromium.org/2418003/diff/1/3#newcode25 views/controls/button/image_button.h:25: virtual void SetImage(ButtonState aState, const SkBitmap* anImage); On 2010/06/02 ...
10 years, 6 months ago (2010-06-02 18:39:40 UTC) #3
sky
10 years, 6 months ago (2010-06-02 19:25:07 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698