Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Issue 2417703002: Fix an issue running mash in chrome: (Closed)

Created:
4 years, 2 months ago by Ben Goodger (Google)
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue running mash in chrome: - add missing capability provision that allows service manager to locate chrome's mash ServiceFactory - adds more debug info to InterfaceRegistry to make solving this kind of thing easier. R=sky@chromium.org,tsepez@chromium.org Committed: https://crrev.com/9be00c4c95a3081cbc354c8b797b03d333e911e6 Cr-Commit-Position: refs/heads/master@{#424953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/app/mash/chrome_mash_manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
M services/shell/public/cpp/interface_registry.h View 2 chunks +3 lines, -1 line 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/service_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Ben Goodger (Google)
4 years, 2 months ago (2016-10-12 22:34:46 UTC) #1
sky
LGTM
4 years, 2 months ago (2016-10-12 23:01:07 UTC) #4
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-12 23:56:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417703002/1
4 years, 2 months ago (2016-10-13 04:07:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 04:13:37 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 04:15:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9be00c4c95a3081cbc354c8b797b03d333e911e6
Cr-Commit-Position: refs/heads/master@{#424953}

Powered by Google App Engine
This is Rietveld 408576698