Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: services/shell/public/cpp/lib/interface_registry.cc

Issue 2417703002: Fix an issue running mash in chrome: (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/public/cpp/interface_registry.h ('k') | services/shell/public/cpp/lib/service_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/public/cpp/lib/interface_registry.cc
diff --git a/services/shell/public/cpp/lib/interface_registry.cc b/services/shell/public/cpp/lib/interface_registry.cc
index f992e7da60f0d412438ab19bd2cdad457909add1..2169bac01bd40c96170700a9174a00473f7b1c30 100644
--- a/services/shell/public/cpp/lib/interface_registry.cc
+++ b/services/shell/public/cpp/lib/interface_registry.cc
@@ -15,9 +15,11 @@ InterfaceRegistry::InterfaceRegistry()
: binding_(this), allow_all_interfaces_(true), weak_factory_(this) {}
InterfaceRegistry::InterfaceRegistry(
+ const Identity& local_identity,
const Identity& remote_identity,
const CapabilityRequest& capability_request)
: binding_(this),
+ local_identity_(local_identity),
remote_identity_(remote_identity),
capability_request_(capability_request),
allow_all_interfaces_(capability_request.interfaces.size() == 1 &&
@@ -95,13 +97,16 @@ void InterfaceRegistry::GetInterface(const std::string& interface_name,
} else if (!CanBindRequestForInterface(interface_name)) {
std::stringstream ss;
ss << "Capability spec prevented service " << remote_identity_.name()
- << " from binding interface: " << interface_name;
+ << " from binding interface: " << interface_name
+ << " exposed by: " << local_identity_.name();
LOG(ERROR) << ss.str();
mojo::ReportBadMessage(ss.str());
} else if (!default_binder_.is_null()) {
default_binder_.Run(interface_name, std::move(handle));
} else {
- LOG(ERROR) << "Failed to locate a binder for interface: " << interface_name;
+ LOG(ERROR) << "Failed to locate a binder for interface: " << interface_name
+ << " requested by: " << remote_identity_.name()
+ << " exposed by: " << local_identity_.name();
}
}
« no previous file with comments | « services/shell/public/cpp/interface_registry.h ('k') | services/shell/public/cpp/lib/service_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698