Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2417643005: DevTools: Allow EvaluateScript event with no arguments. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Allow EvaluateScript event with no arguments. BUG=655430 Committed: https://crrev.com/afc0e803ee2205a7b456b93fb9a33c0b523216a7 Cr-Commit-Position: refs/heads/master@{#425494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alph
4 years, 2 months ago (2016-10-13 21:37:48 UTC) #2
caseq
lgtm
4 years, 2 months ago (2016-10-14 22:21:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417643005/1
4 years, 2 months ago (2016-10-14 22:28:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 22:34:45 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 22:36:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afc0e803ee2205a7b456b93fb9a33c0b523216a7
Cr-Commit-Position: refs/heads/master@{#425494}

Powered by Google App Engine
This is Rietveld 408576698