Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2417643005: DevTools: Allow EvaluateScript event with no arguments. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 94e32e09bd52bfdf29111f3d94c984d87c64ad15..8043805990e102c3c5bb16cff7684376d1c72c34 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -428,7 +428,7 @@ WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent = function(event, tar
case recordType.CompileScript:
case recordType.EvaluateScript:
- var url = eventData["url"];
+ var url = eventData && eventData["url"];
if (url)
detailsText = WebInspector.displayNameForURL(url) + ":" + (eventData["lineNumber"] + 1);
break;
@@ -758,7 +758,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
break;
case recordTypes.CompileScript:
case recordTypes.EvaluateScript:
- var url = eventData["url"];
+ var url = eventData && eventData["url"];
if (url)
contentHelper.appendLocationRow(WebInspector.UIString("Script"), url, eventData["lineNumber"], eventData["columnNumber"]);
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698