Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2417643002: Move text input mode/info/type into InputMethodController (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
esprehn
CC:
blink-reviews, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move text input mode/info/type into InputMethodController Collapse common code into a single implementation. I'll further clean this code up this is just meant to re-organize it. BUG=634330 Committed: https://crrev.com/7ba928b7e8f7b1d7dc2cd2830b5c70b6e488a5d2 Cr-Commit-Position: refs/heads/master@{#425405}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -414 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.h View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 2 3 3 chunks +199 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 2 4 chunks +5 lines, -202 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 chunks +5 lines, -204 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (20 generated)
dtapuska
4 years, 2 months ago (2016-10-12 22:33:32 UTC) #11
dtapuska
On 2016/10/12 22:33:32, dtapuska wrote: esprehn@ ping
4 years, 2 months ago (2016-10-13 18:03:41 UTC) #12
esprehn
LGTM, please switch to String before landing. It'll auto convert to a WebString if needed ...
4 years, 2 months ago (2016-10-14 16:49:36 UTC) #13
dtapuska
https://codereview.chromium.org/2417643002/diff/20001/third_party/WebKit/Source/core/editing/InputMethodController.h File third_party/WebKit/Source/core/editing/InputMethodController.h (right): https://codereview.chromium.org/2417643002/diff/20001/third_party/WebKit/Source/core/editing/InputMethodController.h#newcode144 third_party/WebKit/Source/core/editing/InputMethodController.h:144: WebString inputModeOfFocusedElement() const; On 2016/10/14 16:49:35, esprehn wrote: > ...
4 years, 2 months ago (2016-10-14 17:21:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417643002/60001
4 years, 2 months ago (2016-10-14 18:47:32 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-14 18:52:48 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 18:55:16 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7ba928b7e8f7b1d7dc2cd2830b5c70b6e488a5d2
Cr-Commit-Position: refs/heads/master@{#425405}

Powered by Google App Engine
This is Rietveld 408576698