Move text input mode/info/type into InputMethodController

Move text input mode/info/type into InputMethodController

Collapse common code into a single implementation. I'll further
clean this code up this is just meant to re-organize it.

BUG=634330
Committed: https://crrev.com/7ba928b7e8f7b1d7dc2cd2830b5c70b6e488a5d2
Cr-Commit-Position: refs/heads/master@{#425405}

[dtapuska, 2016-10-12 19:58:26]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 19:58:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 20:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 20:02:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dtapuska, 2016-10-12 20:14:36]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 20:15:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 21:17:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 21:17:40]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dtapuska, 2016-10-12 22:33:22]

Description was changed from

==========
Move text input mode/info/type into InputMethodController

Collapse common code into a single implementation. I'll further
clean this code up this is just meant to re-organize it.

BUG=634330
==========

to

==========
Move text input mode/info/type into InputMethodController

Collapse common code into a single implementation. I'll further
clean this code up this is just meant to re-organize it.

BUG=634330
==========

[dtapuska, 2016-10-12 22:33:22]

dtapuska@chromium.org changed reviewers:
+ esprehn@chromium.org

[dtapuska, 2016-10-13 18:03:41]

On 2016/10/12 22:33:32, dtapuska wrote:

esprehn@ ping

[esprehn, 2016-10-14 16:49:36]

LGTM, please switch to String before landing. It'll auto convert to a WebString
if needed in the caller. In general we don't use WebString inside blink since
it's just a wrapper over String.

https://codereview.chromium.org/2417643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/InputMethodController.h (right):

https://codereview.chromium.org/2417643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.h:144: WebString
inputModeOfFocusedElement() const;
No WebString inside core, just use String.

https://codereview.chromium.org/2417643002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/2417643002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:1004: const
AtomicString& autocomplete = element->getAttribute(autocompleteString);
This should already be defined as HTMLNames::autocompleteAttr I think? I see it
in the old code though so you can fix this in another patch.

https://codereview.chromium.org/2417643002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:1010: const
AtomicString& autocorrect = element->getAttribute(autocorrectString);
Ditto

[dtapuska, 2016-10-14 17:00:57]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:01:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-10-14 17:10:31]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:10:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-10-14 17:21:28]

https://codereview.chromium.org/2417643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/InputMethodController.h (right):

https://codereview.chromium.org/2417643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.h:144: WebString
inputModeOfFocusedElement() const;
On 2016/10/14 16:49:35, esprehn wrote:
> No WebString inside core, just use String.

Done.

https://codereview.chromium.org/2417643002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/2417643002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:1004: const
AtomicString& autocomplete = element->getAttribute(autocompleteString);
On 2016/10/14 16:49:35, esprehn wrote:
> This should already be defined as HTMLNames::autocompleteAttr I think? I see
it
> in the old code though so you can fix this in another patch.

Done.

https://codereview.chromium.org/2417643002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:1010: const
AtomicString& autocorrect = element->getAttribute(autocorrectString);
On 2016/10/14 16:49:36, esprehn wrote:
> Ditto

Done.

[commit-bot: I haz the power, 2016-10-14 18:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:45:03]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2016-10-14 18:46:36]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-10-14 18:46:36]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2417643002/#ps60001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-10-14 18:47:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 18:52:47]

Description was changed from

==========
Move text input mode/info/type into InputMethodController

Collapse common code into a single implementation. I'll further
clean this code up this is just meant to re-organize it.

BUG=634330
==========

to

==========
Move text input mode/info/type into InputMethodController

Collapse common code into a single implementation. I'll further
clean this code up this is just meant to re-organize it.

BUG=634330
==========

[commit-bot: I haz the power, 2016-10-14 18:52:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-14 18:55:14]

Description was changed from

==========
Move text input mode/info/type into InputMethodController

Collapse common code into a single implementation. I'll further
clean this code up this is just meant to re-organize it.

BUG=634330
==========

to

==========
Move text input mode/info/type into InputMethodController

Collapse common code into a single implementation. I'll further
clean this code up this is just meant to re-organize it.

BUG=634330

Committed: https://crrev.com/7ba928b7e8f7b1d7dc2cd2830b5c70b6e488a5d2
Cr-Commit-Position: refs/heads/master@{#425405}
==========

[commit-bot: I haz the power, 2016-10-14 18:55:16]

Patchset 4 (id:??) landed as
https://crrev.com/7ba928b7e8f7b1d7dc2cd2830b5c70b6e488a5d2
Cr-Commit-Position: refs/heads/master@{#425405}