Define WebTextInputMode as a enum in the public API.

Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
TBR=shuchen@chromium.org

Committed: https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3
Cr-Commit-Position: refs/heads/master@{#427352}

[dtapuska, 2016-10-14 16:19:28]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2016-10-14 16:19:59]

dtapuska@chromium.org changed reviewers:
+ esprehn@chromium.org

[commit-bot: I haz the power, 2016-10-14 16:20:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 16:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 16:22:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dtapuska, 2016-10-14 17:22:05]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 17:50:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 17:50:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dtapuska, 2016-10-19 15:32:41]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 15:33:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-10-19 15:42:02]

On 2016/10/14 16:19:59, dtapuska wrote:

esprehn@ ping

[commit-bot: I haz the power, 2016-10-19 15:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 15:55:46]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dtapuska, 2016-10-19 16:14:13]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 16:14:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 17:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 17:53:00]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-10-24 21:12:26]

lgtm

https://codereview.chromium.org/2422663002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/WebViewTest.cpp (right):

https://codereview.chromium.org/2422663002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/WebViewTest.cpp:812:
testInputMode(WebTextInputMode::kWebTextInputModeVerbatim,
All of this seems like it should be unit tests inside blink, loading a whole
file on disk is super overkill for what's being tested.

[dtapuska, 2016-10-25 13:07:23]

dtapuska@chromium.org changed reviewers:
+ shuchen@chromium.org

[dtapuska, 2016-10-25 13:07:24]

shuchen@chromium.org: Please review changes in 

ui/base/ime/

[dtapuska, 2016-10-25 13:20:02]

Description was changed from

==========
Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
==========

to

==========
Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
TBR=shuchen@chromium.org
==========

[dtapuska, 2016-10-25 13:21:06]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-10-25 13:21:06]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2422663002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-25 13:21:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shu Chen, 2016-10-25 13:22:14]

lgtm

[commit-bot: I haz the power, 2016-10-25 15:11:36]

Description was changed from

==========
Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
TBR=shuchen@chromium.org
==========

to

==========
Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
TBR=shuchen@chromium.org
==========

[commit-bot: I haz the power, 2016-10-25 15:11:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-25 15:43:39]

Description was changed from

==========
Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
TBR=shuchen@chromium.org
==========

to

==========
Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
TBR=shuchen@chromium.org

Committed: https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3
Cr-Commit-Position: refs/heads/master@{#427352}
==========

[commit-bot: I haz the power, 2016-10-25 15:43:41]

Patchset 5 (id:??) landed as
https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3
Cr-Commit-Position: refs/heads/master@{#427352}