Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2417613003: Remove usage of FOR_EACH_OBSERVER macro in ui/compositor/. (Closed)

Created:
4 years, 2 months ago by loyso (OOO)
Modified:
4 years, 2 months ago
Reviewers:
Ian Vollick, danakj
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in ui/compositor/. Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/9ec6a6fc99af367856742f4a55cd916e13002759 Cr-Commit-Position: refs/heads/master@{#425228}

Patch Set 1 #

Patch Set 2 : Add missing entries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -44 lines) Patch
M ui/compositor/compositor.cc View 1 5 chunks +18 lines, -23 lines 0 comments Download
M ui/compositor/compositor_vsync_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 1 2 chunks +10 lines, -14 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
loyso (OOO)
4 years, 2 months ago (2016-10-13 04:49:05 UTC) #5
danakj
driveby LGTM
4 years, 2 months ago (2016-10-13 19:36:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417613003/20001
4 years, 2 months ago (2016-10-13 23:53:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 01:16:57 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 01:19:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ec6a6fc99af367856742f4a55cd916e13002759
Cr-Commit-Position: refs/heads/master@{#425228}

Powered by Google App Engine
This is Rietveld 408576698