Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2417423002: Remove usage of FOR_EACH_OBSERVER macro in gin (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in gin Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/061fa6fc79808afd84bc34ca2e6d9e8ae7e21785 Cr-Commit-Position: refs/heads/master@{#425657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gin/modules/module_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:14:47 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-17 09:53:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417423002/1
4 years, 2 months ago (2016-10-17 10:27:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 11:23:01 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 11:25:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/061fa6fc79808afd84bc34ca2e6d9e8ae7e21785
Cr-Commit-Position: refs/heads/master@{#425657}

Powered by Google App Engine
This is Rietveld 408576698