Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: gin/modules/module_registry.cc

Issue 2417423002: Remove usage of FOR_EACH_OBSERVER macro in gin (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/module_registry.cc
diff --git a/gin/modules/module_registry.cc b/gin/modules/module_registry.cc
index bf11ec8d7e5564423fe01911ed33d65d73498324..3e8b47597601d035919bbc419cef4a2628979df4 100644
--- a/gin/modules/module_registry.cc
+++ b/gin/modules/module_registry.cc
@@ -163,8 +163,8 @@ void ModuleRegistry::AddPendingModule(Isolate* isolate,
const std::string pending_id = pending->id;
const std::vector<std::string> pending_dependencies = pending->dependencies;
AttemptToLoad(isolate, std::move(pending));
- FOR_EACH_OBSERVER(ModuleRegistryObserver, observer_list_,
- OnDidAddPendingModule(pending_id, pending_dependencies));
+ for (auto& observer : observer_list_)
+ observer.OnDidAddPendingModule(pending_id, pending_dependencies);
}
void ModuleRegistry::LoadModule(Isolate* isolate,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698