PaymentRequest: Rename includeName parameter to includeNameInLabel.

PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was initiated by the follwing link:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none

Committed: https://crrev.com/5a99e12bef4b45266f4a7489050fcabf474104c0
Cr-Commit-Position: refs/heads/master@{#425689}

[zino, 2016-10-14 18:56:06]

Description was changed from

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was raised the follwing links:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none
==========

to

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was raised the follwing links:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none
==========

[zino, 2016-10-14 18:56:06]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org, tedchoc@chromium.org

[zino, 2016-10-14 18:57:16]

PTAL.

This is a trivial patch.

[zino, 2016-10-14 19:03:58]

Description was changed from

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was raised the follwing links:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none
==========

to

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was initiated by the follwing link:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none
==========

[Ted C, 2016-10-14 20:43:18]

lgtm

[please use gerrit instead, 2016-10-17 14:52:07]

LGTM other than the typo. Feel free to submit after the typo is fixed.

https://codereview.chromium.org/2417353002/diff/1/chrome/browser/autofill/and...
File chrome/browser/autofill/android/personal_data_manager_android.h (right):

https://codereview.chromium.org/2417353002/diff/1/chrome/browser/autofill/and...
chrome/browser/autofill/android/personal_data_manager_android.h:82: //
|include_name_in_lael| argument controls whether the name is included.
Typo: lael --> label.

[please use gerrit instead, 2016-10-17 14:52:41]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2016-10-17 14:52:41]

mathp@: OWNER PTAL personal_data_manager_android.h/cc.

[Mathieu, 2016-10-17 14:55:25]

rubber stamp lgtm

[zino, 2016-10-17 15:15:38]

Good catch. Thanks.

https://codereview.chromium.org/2417353002/diff/1/chrome/browser/autofill/and...
File chrome/browser/autofill/android/personal_data_manager_android.h (right):

https://codereview.chromium.org/2417353002/diff/1/chrome/browser/autofill/and...
chrome/browser/autofill/android/personal_data_manager_android.h:82: //
|include_name_in_lael| argument controls whether the name is included.
On 2016/10/17 14:52:06, rouslan (slow 10.10-10.17) wrote:
> Typo: lael --> label.

Done.

[zino, 2016-10-17 15:15:43]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2016-10-17 15:15:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mathp@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2417353002/#ps20001
(title: "PaymentRequest: Rename includeName parameter to includeNameInLabel.")

[commit-bot: I haz the power, 2016-10-17 15:15:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 15:51:38]

Description was changed from

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was initiated by the follwing link:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none
==========

to

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was initiated by the follwing link:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none
==========

[commit-bot: I haz the power, 2016-10-17 15:51:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-17 15:53:58]

Description was changed from

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was initiated by the follwing link:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none
==========

to

==========
PaymentRequest: Rename includeName parameter to includeNameInLabel.

The includeName paramter is used in getProfilesToSuggest() in order to determine
whether to include the name in the profile's label when getting profiles. But it
can give a feeling which means the data in the profile itself. So, we should
rename it to better name. (s/includeName/includeNameInLabel)

This CL was initiated by the follwing link:
  https://codereview.chromium.org/2368073002/patch/240001/250003

BUG=none

Committed: https://crrev.com/5a99e12bef4b45266f4a7489050fcabf474104c0
Cr-Commit-Position: refs/heads/master@{#425689}
==========

[commit-bot: I haz the power, 2016-10-17 15:53:59]

Patchset 2 (id:??) landed as
https://crrev.com/5a99e12bef4b45266f4a7489050fcabf474104c0
Cr-Commit-Position: refs/heads/master@{#425689}