chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java - Issue 2417353002: PaymentRequest: Rename includeName parameter to includeNameInLabel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java

Issue 2417353002: PaymentRequest: Rename includeName parameter to includeNameInLabel. (Closed)

Patch Set: PaymentRequest: Rename includeName parameter to includeNameInLabel. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java ('k') | chrome/browser/autofill/android/personal_data_manager_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java

index c0be4f4ca7a50d9bfc41d88fc0ebbd94b64502e4..748348714b0c9ef0191552fd58a137791da9e1b2 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java

@@ -325,7 +325,8 @@ public class PersonalDataManagerTest extends NativeLibraryTestBase {

// a bigger use count that the first profile. It should be second.

mHelper.setProfileUseStatsForTesting(guid3, 6, 5000);

- List<AutofillProfile> profiles = mHelper.getProfilesToSuggest(false /* includeName */);

+ List<AutofillProfile> profiles =

+ mHelper.getProfilesToSuggest(false /* includeNameInLabel */);

assertEquals(3, profiles.size());

assertTrue("Profile2 should be ranked first", guid2.equals(profiles.get(0).getGUID()));

assertTrue("Profile3 should be ranked second", guid3.equals(profiles.get(1).getGUID()));

@@ -499,7 +500,8 @@ public class PersonalDataManagerTest extends NativeLibraryTestBase {

TimeoutException {

mHelper.setProfile(createTestProfile());

- List<AutofillProfile> profiles = mHelper.getProfilesToSuggest(false /* includeName */);

+ List<AutofillProfile> profiles =

+ mHelper.getProfilesToSuggest(false /* includeNameInLabel */);

assertEquals("Acme Inc., 123 Main, Los Angeles, California 90210, United States",

profiles.get(0).getLabel());

}

@@ -511,7 +513,8 @@ public class PersonalDataManagerTest extends NativeLibraryTestBase {

TimeoutException {

mHelper.setProfile(createTestProfile());

- List<AutofillProfile> profiles = mHelper.getProfilesToSuggest(true /* includeName */);

+ List<AutofillProfile> profiles =

+ mHelper.getProfilesToSuggest(true /* includeNameInLabel */);

assertEquals("John Major, Acme Inc., 123 Main, Los Angeles, California 90210, "

+ "United States", profiles.get(0).getLabel());

}