Chromium Code Reviews
Description[Merge M55] aw: Fix effective frame source leak after detach
shouqun@ discovered that destroying the SurfaceFactory before all
resources belonging to that surface are returned will lead to those
resources being dropped completely, since cc::Display only holds onto a
weakptr to SurfaceFactory to return resources.
Webview goes through this cycle each time it's detached and re-attached,
so the "lost" resources will keep growing until the memory budget is
reached. Note though that destroying the webview does free these
resources, so they are not lost forever. But detach/attach is very
common, and this is still a severe leak.
Fix by submitting an empty frame into the Surface, which forces
resources from the previous frame to be returned.
BUG=655434
Review-Url: https://codereview.chromium.org/2423473002
Cr-Commit-Position: refs/heads/master@{#425466}
(cherry picked from commit 2fd5e46f7fba4945e86a5c4cd9297a6eaf2417df)
Committed: https://chromium.googlesource.com/chromium/src/+/75fa605f8ee74897558c6ccba1f6ed525c9d3fe1
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||