aw: Fix effective frame source leak after detach

aw: Fix effective frame source leak after detach

shouqun@ discovered that destroying the SurfaceFactory before all
resources belonging to that surface are returned will lead to those
resources being dropped completely, since cc::Display only holds onto a
weakptr to SurfaceFactory to return resources.

Webview goes through this cycle each time it's detached and re-attached,
so the "lost" resources will keep growing until the memory budget is
reached. Note though that destroying the webview does free these
resources, so they are not lost forever. But detach/attach is very
common, and this is still a severe leak.

Fix by submitting an empty frame into the Surface, which forces
resources from the previous frame to be returned.

BUG=655434
Committed: https://crrev.com/2fd5e46f7fba4945e86a5c4cd9297a6eaf2417df
Cr-Commit-Position: refs/heads/master@{#425466}

[boliu, 2016-10-14 17:38:03]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[boliu, 2016-10-14 17:38:16]

boliu@chromium.org changed reviewers:
+ jbauman@chromium.org

[boliu, 2016-10-14 17:38:17]

ptal

[commit-bot: I haz the power, 2016-10-14 17:38:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-10-14 17:44:15]

cc shouqun

[commit-bot: I haz the power, 2016-10-14 18:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:13:59]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-10-14 21:09:08]

lgtm

[boliu, 2016-10-14 21:09:58]

On 2016/10/14 21:09:08, jbauman wrote:
> lgtm

Thanks!

[boliu, 2016-10-14 21:10:03]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-10-14 21:10:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 21:20:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-14 21:21:43]

Description was changed from

==========
aw: Fix effective frame source leak after detach

shouqun@ discovered that destroying the SurfaceFactory before all
resources belonging to that surface are returned will lead to those
resources being dropped completely, since cc::Display only holds onto a
weakptr to SurfaceFactory to return resources.

Webview goes through this cycle each time it's detached and re-attached,
so the "lost" resources will keep growing until the memory budget is
reached. Note though that destroying the webview does free these
resources, so they are not lost forever. But detach/attach is very
common, and this is still a severe leak.

Fix by submitting an empty frame into the Surface, which forces
resources from the previous frame to be returned.

BUG=655434
==========

to

==========
aw: Fix effective frame source leak after detach

shouqun@ discovered that destroying the SurfaceFactory before all
resources belonging to that surface are returned will lead to those
resources being dropped completely, since cc::Display only holds onto a
weakptr to SurfaceFactory to return resources.

Webview goes through this cycle each time it's detached and re-attached,
so the "lost" resources will keep growing until the memory budget is
reached. Note though that destroying the webview does free these
resources, so they are not lost forever. But detach/attach is very
common, and this is still a severe leak.

Fix by submitting an empty frame into the Surface, which forces
resources from the previous frame to be returned.

BUG=655434

Committed: https://crrev.com/2fd5e46f7fba4945e86a5c4cd9297a6eaf2417df
Cr-Commit-Position: refs/heads/master@{#425466}
==========

[commit-bot: I haz the power, 2016-10-14 21:21:44]

Patchset 1 (id:??) landed as
https://crrev.com/2fd5e46f7fba4945e86a5c4cd9297a6eaf2417df
Cr-Commit-Position: refs/heads/master@{#425466}