Issue 2417233002: [Subzero][MIPS32] Fix alloca alignment and offset for Om1 and O2 optimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2417233002: [Subzero][MIPS32] Fix alloca alignment and offset for Om1 and O2 optimization (Closed)

Created:
4 years, 2 months ago by sagar.thakur

Modified:
4 years, 2 months ago

Reviewers:
Eric Holk, Karl, Jim Stichnoth, jaydeep.patil, John

CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com, stefan.maksimovic_imgtec.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -20 lines)			Patch
M	src/IceTargetLoweringMIPS32.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/IceTargetLoweringMIPS32.cpp	View	1	6 chunks	+39 lines, -11 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/alloc.ll	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

sagar.thakur

This change also fixes the cross test mem_intrin for both O2 and Om1.

4 years, 2 months ago (2016-10-14 11:00:55 UTC) #2

Jim Stichnoth

4 years, 2 months ago (2016-10-16 14:20:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
468323715da610429d8d4f2525387fbd2f2165eb (presubmit successful).