wptserve: Do not drop environment variables on running 'serve' command.

wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG=623613
NOTRY=true

Committed: https://crrev.com/e372c95d95d2f58f7b2bfc622cedccd4eed23d83
Cr-Commit-Position: refs/heads/master@{#425344}

[tkent, 2016-10-14 04:36:23]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 04:36:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-14 04:37:20]

Description was changed from

==========
wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG=
==========

to

==========
wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG=623613
==========

[tkent, 2016-10-14 04:39:05]

tkent@chromium.org changed reviewers:
+ jsbell@chromium.org, qyearsley@chromium.org

[tkent, 2016-10-14 04:39:06]

jsbell@ or qyearsley@, would you review this please?

[commit-bot: I haz the power, 2016-10-14 05:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 05:20:22]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-10-14 15:56:37]

Thanks for investigating this :-)

https://codereview.chromium.org/2417153002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
(right):

https://codereview.chromium.org/2417153002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py:53:
self._env = os.environ.copy()
Could you change this to:

  self._env = port_obj.host.environ.copy()

For real Host objects, this should be the same as os.environ, but accessing the
environment variables through host makes it easier to test.

[tkent, 2016-10-14 16:06:08]

Description was changed from

==========
wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG=623613
==========

to

==========
wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG=623613
NOTRY=true
==========

[tkent, 2016-10-14 16:07:05]

https://codereview.chromium.org/2417153002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
(right):

https://codereview.chromium.org/2417153002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py:53:
self._env = os.environ.copy()
On 2016/10/14 at 15:56:37, qyearsley wrote:
> Could you change this to:
> 
>   self._env = port_obj.host.environ.copy()
> 
> For real Host objects, this should be the same as os.environ, but accessing
the environment variables through host makes it easier to test.

Done.
I haven't tested Patch Set 2 on Windows.  A Windows machine is not available
just now.

[qyearsley, 2016-10-14 16:11:10]

lgtm

[tkent, 2016-10-14 16:13:42]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-10-14 16:14:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 16:20:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 16:24:27]

Description was changed from

==========
wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG=623613
NOTRY=true
==========

to

==========
wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG=623613
NOTRY=true

Committed: https://crrev.com/e372c95d95d2f58f7b2bfc622cedccd4eed23d83
Cr-Commit-Position: refs/heads/master@{#425344}
==========

[commit-bot: I haz the power, 2016-10-14 16:24:28]

Patchset 2 (id:??) landed as
https://crrev.com/e372c95d95d2f58f7b2bfc622cedccd4eed23d83
Cr-Commit-Position: refs/heads/master@{#425344}