third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py - Issue 2417153002: wptserve: Do not drop environment variables on running 'serve' command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Issue 2417153002: wptserve: Do not drop environment variables on running 'serve' command. (Closed)

Patch Set: port_obj.host.environ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

index 861d0b0f44569acb6a1732b2713b024c2a16b999..aaec90835b40b9aa7d27afefdb29b0f85b81ba18 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

@@ -48,7 +48,8 @@ class WPTServe(server_base.ServerBase):

self._stdout = self._stderr = self._executive.DEVNULL

# TODO(burnik): We should stop setting the CWD once WPT can be run without it.

self._cwd = path_to_wpt_root

- self._env = {'PYTHONPATH': path_to_thirdparty}

+ self._env = port_obj.host.environ.copy()

+ self._env.update({'PYTHONPATH': path_to_thirdparty})

self._keep_process_reference = True

self._start_cmd = start_cmd

« no previous file with comments | « no previous file | no next file » | no next file with comments »