Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2417133002: [M54] Merge Linux ChromeOS Buildspec browsertest fix (Closed)

Created:
4 years, 2 months ago by lpique
Modified:
4 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, bhthompson
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[M54] Merge Linux ChromeOS Buildspec browsertest fix This is https://crrev.com/423a6fda4bb8157ef5f1753657ac2eed6868b04a applied to the M54 branch, which needed it. A number of browsertests have been failing on the builder for quite a while due to the Python path not being set quite right. https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20ChromeOS%20Buildspec%20Tests Tested by building for Chrome for ChromeOS locally, and running the browsertests. None of the tests mentioned in the bug failed. BUG=654561 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/policy/test/local_policy_test_server.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
lpique
PTAL.
4 years, 2 months ago (2016-10-14 01:26:24 UTC) #3
lpique
Brett, PTAL.
4 years, 2 months ago (2016-10-14 19:11:14 UTC) #5
brettw
lgtm
4 years, 2 months ago (2016-10-14 19:18:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417133002/1
4 years, 2 months ago (2016-10-14 19:56:20 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 2 months ago (2016-10-14 19:56:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417133002/1
4 years, 2 months ago (2016-10-14 19:57:52 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 20:05:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698