Rename Artwork to MediaImage on the Java side

Rename Artwork to MediaImage on the Java side

The MediaSession spec is using name "MediaImage" instead
of "Artwork". This CL fixes the naming on the Java side to match
the spec.

Spec page:
https://wicg.github.io/mediasession/#mediaimage

BUG=616411
Committed: https://crrev.com/3897c97d78b0f392d83d02e8bc7b9dce9fa3720c
Cr-Commit-Position: refs/heads/master@{#425345}

[Zhiqiang Zhang (Slow), 2016-10-13 18:45:51]

Description was changed from

==========
Rename Artwork -> MediaImage on Java side

BUG=616411
==========

to

==========
Fix MediaImage on the Java side

This CL fixes naming of MediaImage on the Java side, and fixes comparison and
hashing issues as well.

BUG=616411
==========

[Zhiqiang Zhang (Slow), 2016-10-13 18:46:02]

zqzhang@chromium.org changed reviewers:
+ boliu@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-13 18:48:59]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 18:49:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:25:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:25:25]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-10-13 21:15:28]

can you split the rename renmae into a separate CL from the other functional
changes?

can you explain why it's being renamed in the CL description?

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java
(right):

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:96:
&& mSizes.equals(other.mSizes);
so this isn't totally correct (or at least it's ambiguous what is correct) for
subclasses, but I guess in practice there aren't going to be subclasses, right?
make the class final then?

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:101:
int result = mSrc.hashCode();
where does this algorithm come from? why is this a good algorithm?

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:208:
public MediaMetadata(@NonNull String title, @NonNull String artist, @NonNull
String album,
what's calling this constructor? can the one above be removed? If it's only
called from create, then it should be private

[Zhiqiang Zhang (Slow), 2016-10-14 10:17:09]

Description was changed from

==========
Fix MediaImage on the Java side

This CL fixes naming of MediaImage on the Java side, and fixes comparison and
hashing issues as well.

BUG=616411
==========

to

==========
Rename Artwork to MediaImage on the Java side

The MediaSession spec is using name "MediaImage" instead
of "Artwork". This CL fixes the naming on the Java side to match
the spec.

Spec page:
https://wicg.github.io/mediasession/#mediaimage

BUG=616411
==========

[Zhiqiang Zhang (Slow), 2016-10-14 10:40:50]

PTAL.

Thanks for the comments. Made this CL only for renaming, will do the rest in
another CL.

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java
(right):

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:96:
&& mSizes.equals(other.mSizes);
On 2016/10/13 21:15:27, boliu wrote:
> so this isn't totally correct (or at least it's ambiguous what is correct) for
> subclasses, but I guess in practice there aren't going to be subclasses,
right?
> make the class final then?

Thanks. Moved this to a separate CL, will do it there.

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:101:
int result = mSrc.hashCode();
On 2016/10/13 21:15:27, boliu wrote:
> where does this algorithm come from? why is this a good algorithm?

Java List<>.hashCode() uses this algorithm to combine hash values. So I think it
is generally OK?

https://codereview.chromium.org/2417013002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:208:
public MediaMetadata(@NonNull String title, @NonNull String artist, @NonNull
String album,
On 2016/10/13 21:15:27, boliu wrote:
> what's calling this constructor? can the one above be removed? If it's only
> called from create, then it should be private

Moved this CL to a separate one and will do it there.

[boliu, 2016-10-14 15:44:44]

lgtm

[Zhiqiang Zhang (Slow), 2016-10-14 15:50:19]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-10-14 15:50:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 16:21:42]

Description was changed from

==========
Rename Artwork to MediaImage on the Java side

The MediaSession spec is using name "MediaImage" instead
of "Artwork". This CL fixes the naming on the Java side to match
the spec.

Spec page:
https://wicg.github.io/mediasession/#mediaimage

BUG=616411
==========

to

==========
Rename Artwork to MediaImage on the Java side

The MediaSession spec is using name "MediaImage" instead
of "Artwork". This CL fixes the naming on the Java side to match
the spec.

Spec page:
https://wicg.github.io/mediasession/#mediaimage

BUG=616411
==========

[commit-bot: I haz the power, 2016-10-14 16:21:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 16:24:29]

Description was changed from

==========
Rename Artwork to MediaImage on the Java side

The MediaSession spec is using name "MediaImage" instead
of "Artwork". This CL fixes the naming on the Java side to match
the spec.

Spec page:
https://wicg.github.io/mediasession/#mediaimage

BUG=616411
==========

to

==========
Rename Artwork to MediaImage on the Java side

The MediaSession spec is using name "MediaImage" instead
of "Artwork". This CL fixes the naming on the Java side to match
the spec.

Spec page:
https://wicg.github.io/mediasession/#mediaimage

BUG=616411

Committed: https://crrev.com/3897c97d78b0f392d83d02e8bc7b9dce9fa3720c
Cr-Commit-Position: refs/heads/master@{#425345}
==========

[commit-bot: I haz the power, 2016-10-14 16:24:30]

Patchset 2 (id:??) landed as
https://crrev.com/3897c97d78b0f392d83d02e8bc7b9dce9fa3720c
Cr-Commit-Position: refs/heads/master@{#425345}