Fix several issues of Java MediaMetadata

Fix several issues of Java MediaMetadata

This CL fixes several issues with Java MediaMetadata:
- Removed unused copy constructor.
- Fixes equals() and hashCode().

BUG=None

Committed: https://crrev.com/9fabcdb65ae443280cc402c3606866e525c039da
Cr-Commit-Position: refs/heads/master@{#425375}

[Zhiqiang Zhang (Slow), 2016-10-14 12:17:44]

zqzhang@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2016-10-14 15:50:03]

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java
(right):

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:31:
private String mType;
can mType be null? need to to check fo rnull in equals/hashCode?

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:100:
public int hashCode() {
can you document this is from List then?

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:222:
int result = mTitle.hashCode();
ditto about documentation

[Zhiqiang Zhang (Slow), 2016-10-14 16:00:05]

Thanks for the review. PTAL!

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java
(right):

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:31:
private String mType;
On 2016/10/14 15:50:03, boliu wrote:
> can mType be null? need to to check fo rnull in equals/hashCode?

Thanks. All users of this class assume the members are non-null. Added @NonNull
for all necessary places.

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:100:
public int hashCode() {
On 2016/10/14 15:50:03, boliu wrote:
> can you document this is from List then?

Done.

https://codereview.chromium.org/2414193003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:222:
int result = mTitle.hashCode();
On 2016/10/14 15:50:03, boliu wrote:
> ditto about documentation

Done.

[boliu, 2016-10-14 16:02:09]

lgtm

[Zhiqiang Zhang (Slow), 2016-10-14 16:57:48]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-14 16:57:49]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2414193003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-10-14 16:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 17:33:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-14 17:37:01]

Description was changed from

==========
Fix several issues of Java MediaMetadata

This CL fixes several issues with Java MediaMetadata:
- Removed unused copy constructor.
- Fixes equals() and hashCode().

BUG=None
==========

to

==========
Fix several issues of Java MediaMetadata

This CL fixes several issues with Java MediaMetadata:
- Removed unused copy constructor.
- Fixes equals() and hashCode().

BUG=None

Committed: https://crrev.com/9fabcdb65ae443280cc402c3606866e525c039da
Cr-Commit-Position: refs/heads/master@{#425375}
==========

[commit-bot: I haz the power, 2016-10-14 17:37:02]

Patchset 3 (id:??) landed as
https://crrev.com/9fabcdb65ae443280cc402c3606866e525c039da
Cr-Commit-Position: refs/heads/master@{#425375}