Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2414193003: Fix several issues of Java MediaMetadata (Closed)

Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix several issues of Java MediaMetadata This CL fixes several issues with Java MediaMetadata: - Removed unused copy constructor. - Fixes equals() and hashCode(). BUG=None Committed: https://crrev.com/9fabcdb65ae443280cc402c3606866e525c039da Cr-Commit-Position: refs/heads/master@{#425375}

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed boliu's comments #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java View 1 8 chunks +40 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Zhiqiang Zhang (Slow)
4 years, 2 months ago (2016-10-14 12:17:45 UTC) #2
boliu
https://codereview.chromium.org/2414193003/diff/1/content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java File content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java (right): https://codereview.chromium.org/2414193003/diff/1/content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java#newcode31 content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:31: private String mType; can mType be null? need to ...
4 years, 2 months ago (2016-10-14 15:50:03 UTC) #3
Zhiqiang Zhang (Slow)
Thanks for the review. PTAL! https://codereview.chromium.org/2414193003/diff/1/content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java File content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java (right): https://codereview.chromium.org/2414193003/diff/1/content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java#newcode31 content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java:31: private String mType; On ...
4 years, 2 months ago (2016-10-14 16:00:05 UTC) #4
boliu
lgtm
4 years, 2 months ago (2016-10-14 16:02:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414193003/40001
4 years, 2 months ago (2016-10-14 16:58:19 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-14 17:33:58 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:37:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9fabcdb65ae443280cc402c3606866e525c039da
Cr-Commit-Position: refs/heads/master@{#425375}

Powered by Google App Engine
This is Rietveld 408576698