content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html - Issue 2416953002: Improve gpu pixel tests for OffscreenCanvas 2d

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html

Issue 2416953002: Improve gpu pixel tests for OffscreenCanvas 2d (Closed)

Patch Set: point to the correct bug Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html » ('j') | content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html

diff --git a/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html b/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html

index 23871373537c421aa6486b830f709be23665aab4..4159ebccf7deffb0cac58a69b59f5145ff473a29 100644

--- a/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html

+++ b/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html

@@ -8,7 +8,7 @@ that the baseline images are regenerated on the next run.

<html>

<head>

-<title>OffscreenCanvas 2d commit flow on main thread: blue square on white background.</title>

+<title>OffscreenCanvas 2d commit flow on main thread: Four-color squares on white background.</title>

.nomargin {

margin: 0px auto;

@@ -27,10 +27,16 @@ function draw()

{

var canvas = document.getElementById("c");

var offscreenCanvas = canvas.transferControlToOffscreen();

- var ctx2d = offscreenCanvas.getContext("2d");

- ctx2d.fillStyle = "blue";

- ctx2d.fillRect(0, 0, offscreenCanvas.width, offscreenCanvas.height);

- ctx2d.commit();

+ var offscreen2d = offscreenCanvas.getContext("2d");

+ offscreen2d.fillStyle = "red";

+ offscreen2d.fillRect(0, 0, 100, 100);

+ offscreen2d.fillStyle = "green";

+ offscreen2d.fillRect(100, 0, 200, 100);

xidachen 2016/10/13 17:07:50 I think the last two parameters are width && heigh

xlai (Olivia) 2016/10/13 18:48:24 Done.

+ offscreen2d.fillStyle = "blue";

+ offscreen2d.fillRect(0, 100, 100, 200);

+ offscreen2d.fillStyle = "black";

+ offscreen2d.fillRect(100, 100, 200, 200);

+ offscreen2d.commit();

}

function waitForFinish()

@@ -47,10 +53,10 @@ function waitForFinish()

</script>

</head>

-<div style="position:relative; width:350px; height:350px; background-color:white">

+<div style="position:relative; width:300px; height:300px; background-color:white">

</div>

-<canvas id="c" width="320" height="320" class="nomargin"></canvas>

+<canvas id="c" width="200" height="200" class="nomargin"></canvas>

</div>

</body>

</html>