Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2416903002: Revert of Reland Wait cloudtail termination in goma module (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Reland Wait cloudtail termination in goma module (patchset #5 id:80001 of https://codereview.chromium.org/2404213002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=655618 BUG=655618 Original issue's description: > Reland Wait cloudtail termination in goma module > > This is follow up CL for https://codereview.chromium.org/2375843005/ > > Reland of https://codereview.chromium.org/2386073002/ > Fix: > catch and ignore exception OSError of ECHILD from os.waitpid in windows. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/6cd1bbcae072d0125a8aa4b509fb313149773001 TBR=ukai@chromium.org,shinyak@chromium.org,yyanagisawa@chromium.org,vadimsh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/0d13871fde696f554802b5e5076fb51609f8095b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -70 lines) Patch
M scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py View 3 chunks +1 line, -70 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tikuta
Created Revert of Reland Wait cloudtail termination in goma module
4 years, 2 months ago (2016-10-13 14:17:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416903002/1
4 years, 2 months ago (2016-10-13 14:17:39 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 14:17:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/0d13871fde696f554802...

Powered by Google App Engine
This is Rietveld 408576698