Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

Issue 2416903002: Revert of Reland Wait cloudtail termination in goma module (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2016 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import errno 7 import errno
8 import os 8 import os
9 import signal 9 import signal
10 import subprocess 10 import subprocess
11 import sys 11 import sys
12 import time
13 12
14 from slave import goma_utils 13 from slave import goma_utils
15 14
16 15
17 def start_cloudtail(args): 16 def start_cloudtail(args):
18 """Write process id of started cloudtail to file object f""" 17 """Write process id of started cloudtail to file object f"""
19 18
20 proc = subprocess.Popen([args.cloudtail_path, 19 proc = subprocess.Popen([args.cloudtail_path,
21 'tail', 20 'tail',
22 '--log-id', 'goma_compiler_proxy', 21 '--log-id', 'goma_compiler_proxy',
23 '--path', 22 '--path',
24 goma_utils.GetLatestGomaCompilerProxyInfo()]) 23 goma_utils.GetLatestGomaCompilerProxyInfo()])
25 with open(args.pid_file, 'w') as f: 24 with open(args.pid_file, 'w') as f:
26 f.write(str(proc.pid)) 25 f.write(str(proc.pid))
27 26
28
29 def is_running_posix(pid):
30 """Return True if process of pid is running.
31
32 Args:
33 pid(int): pid of process which this function checks
34 whether it is running or not.
35
36 Returns:
37 bool: True if process of pid is running.
38
39 Raises:
40 OSError if something happens in os.kill(pid, 0)
41 """
42
43 try:
44 os.kill(pid, 0)
45 except OSError as e:
46 if e.errno == errno.ESRCH or e.errno == errno.EPERM:
47 return False
48 raise e
49 return True
50
51
52 class NotDiedError(Exception):
53 def __str__(self):
54 return "NotDiedError"
55
56
57 def wait_termination(pid):
58 """Send SIGINT to pid and wait termination of pid.
59
60 Args:
61 pid(int): pid of process which this function waits termination.
62
63 Raises:
64 OSError: is_running_posix, os.waitpid and os.kill may throw OSError.
65 NotDiedError: if cloudtail is running after 10 seconds waiting,
66 NotDiedError is raised.
67 """
68
69 os.kill(pid, signal.SIGINT)
70
71 if os.name == 'nt':
72 try:
73 os.waitpid(pid, 0)
74 except OSError as e:
75 if e.errno == errno.ECHILD:
76 print('process of pid %d died before waitpitd' % pid)
77 return
78 raise e
79 else:
80 for _ in xrange(10):
81 time.sleep(1)
82 if not is_running_posix(pid):
83 return
84
85 print('process %d running more than 10 seconds' % pid)
86 raise NotDiedError()
87
88
89 def main(): 27 def main():
90 parser = argparse.ArgumentParser( 28 parser = argparse.ArgumentParser(
91 description='cloudtail utility for goma recipe module.') 29 description='cloudtail utility for goma recipe module.')
92 30
93 subparsers = parser.add_subparsers(help='commands for cloudtail') 31 subparsers = parser.add_subparsers(help='commands for cloudtail')
94 32
95 parser_start = subparsers.add_parser('start', 33 parser_start = subparsers.add_parser('start',
96 help='subcommand to start cloudtail') 34 help='subcommand to start cloudtail')
97 parser_start.set_defaults(command='start') 35 parser_start.set_defaults(command='start')
98 parser_start.add_argument('--cloudtail-path', required=True, 36 parser_start.add_argument('--cloudtail-path', required=True,
99 help='path of cloudtail binary') 37 help='path of cloudtail binary')
100 parser_start.add_argument('--pid-file', required=True, 38 parser_start.add_argument('--pid-file', required=True,
101 help='file written pid') 39 help='file written pid')
102 40
103 parser_stop = subparsers.add_parser('stop', 41 parser_stop = subparsers.add_parser('stop',
104 help='subcommand to stop cloudtail') 42 help='subcommand to stop cloudtail')
105 parser_stop.set_defaults(command='stop') 43 parser_stop.set_defaults(command='stop')
106 parser_stop.add_argument('--killed-pid-file', required=True, 44 parser_stop.add_argument('--killed-pid-file', required=True,
107 help='file written the pid to be killed.') 45 help='file written the pid to be killed.')
108 46
109 args = parser.parse_args() 47 args = parser.parse_args()
110 48
111 if args.command == 'start': 49 if args.command == 'start':
112 start_cloudtail(args) 50 start_cloudtail(args)
113 elif args.command == 'stop': 51 elif args.command == 'stop':
114 with open(args.killed_pid_file) as f: 52 with open(args.killed_pid_file) as f:
115 # cloudtail flushes log and terminates 53 # cloudtail flushes log and terminates
116 # within 5 seconds when it recieves SIGINT. 54 # within 5 seconds when it recieves SIGINT.
117 pid = int(f.read()) 55 os.kill(int(f.read()), signal.SIGINT)
118 try:
119 wait_termination(int(f.read()))
120 except (OSError, NotDiedError) as e:
121 os.kill(pid, signal.SIGKILL)
122 print('killed process %d due to Error %s' % (pid, e))
123 raise e
124
125 56
126 if '__main__' == __name__: 57 if '__main__' == __name__:
127 sys.exit(main()) 58 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698