Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2416863002: Use fetch_event_id (fetchEventID in blink) for FetchEvent (Closed)

Created:
4 years, 2 months ago by horo
Modified:
4 years, 2 months ago
Reviewers:
keishi, shimazu, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, tzik, jam, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, blink-reviews, falken+watch_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, haraken, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, horo+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fetch_event_id (fetchEventID in blink) for FetchEvent Currently we have |event_finish_id| in both browser and renderer code, but they aren't the same thing. To avoid this confusion, this CL will use |fetch_event_id| (fetchEventID in blink) for FetchEvent handling. And will stop using |event_finish_id| in renderer code by using AddWithID() in ServiceWorkerContextClient::DispatchFetchEvent(). BUG=649558 Committed: https://crrev.com/160d7098f1c9f293990f0a1ee6644442ad945fc9 Cr-Commit-Position: refs/heads/master@{#425255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -91 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M content/common/service_worker/fetch_event_dispatcher.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 7 chunks +18 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 4 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
horo
shimazu@ Could you please review this?
4 years, 2 months ago (2016-10-13 10:50:47 UTC) #5
shimazu
Looks nice refactoring, thanks! lgtm
4 years, 2 months ago (2016-10-14 01:59:24 UTC) #8
horo
keishi@ Could you please review third_party/WebKit/Source/web/*?
4 years, 2 months ago (2016-10-14 02:01:40 UTC) #10
keishi
LGTM
4 years, 2 months ago (2016-10-14 02:08:54 UTC) #11
horo
dcheng@ Could you please review content/common/service_worker/fetch_event_dispatcher.mojom and content/common/service_worker/service_worker_messages.h?
4 years, 2 months ago (2016-10-14 03:41:39 UTC) #13
dcheng
ipc+mojom lgtm
4 years, 2 months ago (2016-10-14 04:16:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416863002/1
4 years, 2 months ago (2016-10-14 04:52:06 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 04:57:46 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 05:00:07 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/160d7098f1c9f293990f0a1ee6644442ad945fc9
Cr-Commit-Position: refs/heads/master@{#425255}

Powered by Google App Engine
This is Rietveld 408576698