third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h - Issue 2416863002: Use fetch_event_id (fetchEventID in blink) for FetchEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2416863002: Use fetch_event_id (fetchEventID in blink) for FetchEvent (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

index 081cc9abb06213824fec7927b240b966e5615786..cdf5b2b5b74ba580b2f5e83b18f9ba7b9bcb1df5 100644

--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

@@ -143,11 +143,12 @@ class WebServiceWorkerContextClient {

// lifecycle. When no response is provided, the browser should fallback to

// native fetch. EventIDs are the same with the ids passed from

// dispatchFetchEvent respectively.

- virtual void respondToFetchEvent(int responseID, double eventDispatchTime) {}

- virtual void respondToFetchEvent(int responseID,

+ virtual void respondToFetchEvent(int fetchEventID, double eventDispatchTime) {

+ }

+ virtual void respondToFetchEvent(int fetchEventID,

const WebServiceWorkerResponse& response,

double eventDispatchTime) {}

- virtual void didHandleFetchEvent(int eventFinishID,

+ virtual void didHandleFetchEvent(int fetchEventID,

WebServiceWorkerEventResult result,

double eventDispatchTime) {}